-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Improve docs for clippy_utils's MSRV support
#15905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome, thank you very much:) I remember spending a non-trivial amount of time trying to figure out what the weird extract_msrv_attr!() call on the bottom of EarlyLintPasses was.
Left just a couple of wording nits
|
Thanks for the feedback! Let me know if you want me to squash my changes together. |
|
I think that'd make sense, yeah:) But note that I won't be able to actually approve the changes afterwards, as I'm not a team member^^ |
This PR adds documentation to
extract_msrv_attr!, improves the documentation onMsrvandMsrvStack, and slightly refactorsMsrv::read_cargo(). While I've usedclippy_utilsbefore, this is my first time interacting with the MSRV side of it, so please check over my writing to make sure it is correct!Let me know if there's anything else I need to do. :)