Skip to content

Conversation

@BD103
Copy link
Contributor

@BD103 BD103 commented Oct 17, 2025

This PR adds documentation to extract_msrv_attr!, improves the documentation on Msrv and MsrvStack, and slightly refactors Msrv::read_cargo(). While I've used clippy_utils before, this is my first time interacting with the MSRV side of it, so please check over my writing to make sure it is correct!

Let me know if there's anything else I need to do. :)

changelog: none

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 17, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 17, 2025

r? @y21

rustbot has assigned @y21.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Copy link
Contributor

@ada4a ada4a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, thank you very much:) I remember spending a non-trivial amount of time trying to figure out what the weird extract_msrv_attr!() call on the bottom of EarlyLintPasses was.

Left just a couple of wording nits

View changes since this review

@BD103
Copy link
Contributor Author

BD103 commented Oct 25, 2025

Thanks for the feedback! Let me know if you want me to squash my changes together.

@ada4a
Copy link
Contributor

ada4a commented Oct 25, 2025

I think that'd make sense, yeah:) But note that I won't be able to actually approve the changes afterwards, as I'm not a team member^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants