-
Notifications
You must be signed in to change notification settings - Fork 68
Propose a 2025H2 goal for comprehensive niche checks #333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7504415
to
dd1dcbe
Compare
RalfJung
reviewed
Jul 16, 2025
4336327
to
5e6e173
Compare
saethlin
reviewed
Jul 17, 2025
saethlin
reviewed
Jul 17, 2025
5e6e173
to
7d71a55
Compare
lqd
reviewed
Jul 18, 2025
7d71a55
to
f6166fc
Compare
shouldn't need to link usernames, avoid extraneous commas
nikomatsakis
approved these changes
Jul 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well-structured, approved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up goal to the previous one that I did in H1. It's continuing the work by making the checks more efficient (broader coverage) and cover all niches.
cc @saethlin, @RalfJung who helped me with the previous goal
Rendered