-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update LLVM to 15.0.7 #106827
Update LLVM to 15.0.7 #106827
Conversation
This commit pulls in rust-lang/llvm-project#143 which updates the LLVM version used by rustc to 15.0.7, namely pulling in https://reviews.llvm.org/D136110 which is needed for some work I'm working on with wasm.
r? @cuviper (rustbot has picked a reviewer for you, use r? to override) |
|
@bors r+ rollup=never |
Thanks for the speedy reviews! Would you be up for rubber-stamping #106644 as well perhaps? If not no worries! |
⌛ Testing commit 50a4612 with merge 645587297bd50bf6bfe30838d2f4d4e4f30f08c4... |
💔 Test failed - checks-actions |
This comment has been minimized.
This comment has been minimized.
Hmm, indeed
... which is new from #106670 (cc @albertlarsan68 @Mark-Simulacrum). I'm guessing that |
Yeah, most likely. I think for now reverting that addition is right (the more principled fix is probably to avoid building LLVM for doc builds). |
Well, the upgrade proved easy enough, and is probably a good idea anyway -- #106948. I think we can consider that revert separately, on its own merits, but it shouldn't block here after that upgrade. |
Thanks for the assistance in tracking this down! I suspected that something like that was happening when I didn't find any cmake changes in the 15.0.6 -> 15.0.7 diff. I'll wait for #106948 which I think should enable a retry of this to go through. |
Could this PR also include rust-lang/llvm-project#144 ? |
Sure thing, I've pulled in that commit here too now |
@bors r+ |
Should rust specific patches be rebased on top, or it ok to keep them where they exist now? |
It's OK to leave it as-is. We'll probably be upgrading to LLVM 16 relatively soon anyway, once that branches. |
☀️ Test successful - checks-actions |
Finished benchmarking commit (5e37043): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. |
This commit pulls in rust-lang/llvm-project#143 which updates the LLVM version used by rustc to 15.0.7, namely pulling in https://reviews.llvm.org/D136110 which is needed for some work I'm working on with wasm.