-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Add a suggestion to add or remove pub on private-in-public error #112540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,6 +8,8 @@ privacy_from_private_dep_in_public_interface = | |
privacy_in_public_interface = {$vis_descr} {$kind} `{$descr}` in public interface | ||
.label = can't leak {$vis_descr} {$kind} | ||
.visibility_label = `{$descr}` declared as {$vis_descr} | ||
.help = - Either remove the `pub` from the function | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This says "from the function" -- but this isn't always fired on a function, is it? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks for reviewing my changes. I am not sure if it's always fired on a function, but you are most likely correct. In that case, what would be a better suggestion? |
||
- Or add `pub` to `{$descr}` | ||
aryan-debug marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
privacy_item_is_private = {$kind} `{$descr}` is private | ||
.label = private {$kind} | ||
|
Uh oh!
There was an error while loading. Please reload this page.