Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update compiler-builtins to 0.1.125 #129992

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

alexcrichton
Copy link
Member

@alexcrichton alexcrichton commented Sep 5, 2024

This commit updates the compiler-builtins crate from 0.1.123 to 0.1.125.
The changes in this update are:

* rust-lang/compiler-builtins#682
* rust-lang/compiler-builtins#678
* rust-lang/compiler-builtins#685
@rustbot
Copy link
Collaborator

rustbot commented Sep 5, 2024

r? @thomcc

rustbot has assigned @thomcc.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 5, 2024
@rustbot
Copy link
Collaborator

rustbot commented Sep 5, 2024

These commits modify the library/Cargo.lock file. Unintentional changes to library/Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Sep 5, 2024
@alexcrichton
Copy link
Member Author

cc @tgross35

@tgross35
Copy link
Contributor

tgross35 commented Sep 5, 2024

This might race because we have a cargo update in the queue, but no concerns here. Thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Sep 5, 2024

📌 Commit 5396124 has been approved by tgross35

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 5, 2024
@tgross35
Copy link
Contributor

tgross35 commented Sep 5, 2024

Ah actually the cargo update still isn't in an active rollup. Might not even conflict but let's just let that go first anyway, r=me after #129624 merges.

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 5, 2024
@alexcrichton
Copy link
Member Author

Sounds good 👍

I'll watch for the merge over there

@tgross35
Copy link
Contributor

That PR is being annoying for some reason, no reason to wait on this since I need to figure that out.

@bors r+

@bors
Copy link
Contributor

bors commented Sep 11, 2024

📌 Commit 5396124 has been approved by tgross35

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 11, 2024
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Sep 11, 2024
…ins, r=tgross35

Update compiler-builtins to 0.1.125

This commit updates the compiler-builtins crate from 0.1.123 to 0.1.125. The changes in this update are:

* rust-lang/compiler-builtins#682
* rust-lang/compiler-builtins#678
* rust-lang/compiler-builtins#685

Fixes: rust-lang#129823
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 11, 2024
…kingjubilee

Rollup of 11 pull requests

Successful merges:

 - rust-lang#119286 (show linker output even if the linker succeeds)
 - rust-lang#129103 (Don't warn empty branches unreachable for now)
 - rust-lang#129696 (update stdarch)
 - rust-lang#129835 (enable const-float-classify test, and test_next_up/down on 32bit x86)
 - rust-lang#129992 (Update compiler-builtins to 0.1.125)
 - rust-lang#130052 (Don't leave debug locations for constants sitting on the builder indefinitely)
 - rust-lang#130077 (Fix linking error when compiling for 32-bit watchOS)
 - rust-lang#130114 (Remove needless returns detected by clippy in the compiler)
 - rust-lang#130156 (Add test for S_OBJNAME & update test for LF_BUILDINFO cl and cmd)
 - rust-lang#130168 (maint: update docs for change_time ext and doc links)
 - rust-lang#130239 (miri: fix overflow detection for unsigned pointer offset)

r? `@ghost`
`@rustbot` modify labels: rollup
@workingjubilee
Copy link
Member

just checking something,
@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 11, 2024
@workingjubilee
Copy link
Member

@bors try

@bors
Copy link
Contributor

bors commented Sep 11, 2024

⌛ Trying commit 5396124 with merge fa8e1ba...

bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 11, 2024
…s, r=<try>

Update compiler-builtins to 0.1.125

This commit updates the compiler-builtins crate from 0.1.123 to 0.1.125. The changes in this update are:

* rust-lang/compiler-builtins#682
* rust-lang/compiler-builtins#678
* rust-lang/compiler-builtins#685

try-job: aarch64-apple
try-job: aarch64-gnu
try-job: armhf-gnu
try-job: test-various
@bors
Copy link
Contributor

bors commented Sep 12, 2024

☀️ Try build successful - checks-actions
Build commit: fa8e1ba (fa8e1ba0c09de2ea77dfded24f107f27a494a899)

@workingjubilee
Copy link
Member

Huh, cool.

@bors r+

@bors
Copy link
Contributor

bors commented Sep 12, 2024

📌 Commit 5396124 has been approved by workingjubilee

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 12, 2024
@workingjubilee
Copy link
Member

oh.
@bors r=tgross35

@bors
Copy link
Contributor

bors commented Sep 12, 2024

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Contributor

bors commented Sep 12, 2024

📌 Commit 5396124 has been approved by tgross35

It is now in the queue for this repository.

@workingjubilee
Copy link
Member

huh, it does use the last approval.

Zalathar added a commit to Zalathar/rust that referenced this pull request Sep 12, 2024
…ins, r=tgross35

Update compiler-builtins to 0.1.125

This commit updates the compiler-builtins crate from 0.1.123 to 0.1.125. The changes in this update are:

* rust-lang/compiler-builtins#682
* rust-lang/compiler-builtins#678
* rust-lang/compiler-builtins#685
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 12, 2024
Rollup of 8 pull requests

Successful merges:

 - rust-lang#129367 (Fix default/minimum deployment target for Aarch64 simulator targets)
 - rust-lang#129992 (Update compiler-builtins to 0.1.125)
 - rust-lang#130052 (Don't leave debug locations for constants sitting on the builder indefinitely)
 - rust-lang#130156 (Add test for S_OBJNAME & update test for LF_BUILDINFO cl and cmd)
 - rust-lang#130160 (Fix `slice::first_mut` docs)
 - rust-lang#130250 (Fix `clippy::useless_conversion`)
 - rust-lang#130252 (Properly report error on `const gen fn`)
 - rust-lang#130256 (Re-run coverage tests if `coverage-dump` was modified)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors
Copy link
Contributor

bors commented Sep 12, 2024

⌛ Testing commit 5396124 with merge 8c0ec05...

@bors
Copy link
Contributor

bors commented Sep 12, 2024

☀️ Test successful - checks-actions
Approved by: tgross35
Pushing 8c0ec05 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 12, 2024
@bors bors merged commit 8c0ec05 into rust-lang:master Sep 12, 2024
7 checks passed
@rustbot rustbot added this to the 1.83.0 milestone Sep 12, 2024
@alexcrichton alexcrichton deleted the update-compiler-builtins branch September 12, 2024 18:38
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (8c0ec05): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary 2.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.1% [2.1%, 2.1%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Cycles

Results (secondary -1.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-1.7% [-1.7%, -1.7%] 1
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 758.82s -> 757.007s (-0.24%)
Artifact size: 341.24 MiB -> 341.21 MiB (-0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hexagon-unknown-none-elf cannot build core, "symbol 'fma' is already defined"
7 participants