Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ABI checks: add support for tier2 arches #132842

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ABI checks: add support for tier2 arches #132842

wants to merge 1 commit into from
+136 −41

Conversation

veluca93
Copy link
Contributor

See #131800 for the data collection behind this change.

r? RalfJung

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 10, 2024
@RalfJung
Copy link
Member

Sorry, I'm going to hand this one off.

r? compiler

@rustbot rustbot assigned cjgillot and unassigned RalfJung Nov 10, 2024
@RalfJung
Copy link
Member

In terms of reviewers, I guess rolling the dice is unlikely to get an ABI person. ;)

r? @workingjubilee

@rustbot rustbot assigned workingjubilee and unassigned cjgillot Nov 10, 2024
@RalfJung RalfJung mentioned this pull request Nov 10, 2024
Open
16 tasks
@veluca93 veluca93 force-pushed the abi-checks-tier2 branch 2 times, most recently from 30a21b5 to 9d3e137 Compare November 10, 2024 16:25
@veluca93 veluca93 force-pushed the abi-checks-tier2 branch 2 times, most recently from 1cc2c1a to ff485c9 Compare November 10, 2024 16:39
workingjubilee
workingjubilee reviewed Nov 11, 2024
View reviewed changes
compiler/rustc_target/src/target_features.rs Show resolved Hide resolved
compiler/rustc_target/src/target_features.rs Outdated Show resolved Hide resolved
compiler/rustc_target/src/target_features.rs Outdated Show resolved Hide resolved
compiler/rustc_target/src/target_features.rs Outdated Show resolved Hide resolved
@bors
Copy link
Contributor

bors commented Nov 12, 2024

☔ The latest upstream changes (presumably #132843) made this pull request unmergeable. Please resolve the merge conflicts.

workingjubilee
workingjubilee reviewed Nov 12, 2024
View reviewed changes
Copy link
Member

@workingjubilee workingjubilee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good as-is, just some notes for future reference if we want.

compiler/rustc_target/src/target_features.rs Show resolved Hide resolved
compiler/rustc_target/src/target_features.rs Outdated Show resolved Hide resolved
compiler/rustc_target/src/target_features.rs Outdated Show resolved Hide resolved
compiler/rustc_target/src/target_features.rs Outdated Show resolved Hide resolved
compiler/rustc_target/src/target_features.rs Outdated Show resolved Hide resolved
@workingjubilee
Copy link
Member

r=me with or without

@bors delegate+

@bors
Copy link
Contributor

bors commented Nov 12, 2024

✌️ @veluca93, you can now approve this pull request!

If @workingjubilee told you to "r=me" after making some further change, please make that change, then do @bors r=@workingjubilee

@veluca93
ABI checks: add support for tier2 arches
295cffc 
See rust-lang#131800 for the data collection behind this change.

Also adds a test that exercise the "empty list of features" path.
@veluca93
Copy link
Contributor Author

Added all the suggested comments (in one form or the other :-))

@bors r=@workingjubilee

@bors
Copy link
Contributor

bors commented Nov 12, 2024

📌 Commit 295cffc has been approved by workingjubilee

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 12, 2024
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Nov 13, 2024
@GuillaumeGomez
Rollup merge of rust-lang#132842 - veluca93:abi-checks-tier2, r=worki…
bd91033 
…ngjubilee

ABI checks: add support for tier2 arches

See rust-lang#131800 for the data collection behind this change.

r? RalfJung
@GuillaumeGomez GuillaumeGomez mentioned this pull request Nov 13, 2024
Open
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 13, 2024
@bors
Auto merge of rust-lang#132989 - GuillaumeGomez:rollup-p5jdno9, r=Gui…
bde4a78 
…llaumeGomez

Rollup of 6 pull requests

Successful merges:

 - rust-lang#132709 (optimize char::to_digit and assert radix is at least 2)
 - rust-lang#132842 (ABI checks: add support for tier2 arches)
 - rust-lang#132965 (allow CFGuard on windows-gnullvm)
 - rust-lang#132967 (fix REGISTRY_USERNAME to reuse cache between auto and pr jobs)
 - rust-lang#132971 (Handle infer vars in anon consts on stable)
 - rust-lang#132979 (use `--exact` on `--skip` to avoid unintended substring matches)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@workingjubilee workingjubilee workingjubilee left review comments

@RalfJung RalfJung RalfJung left review comments

@taiki-e taiki-e taiki-e approved these changes

Assignees

@workingjubilee workingjubilee

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@veluca93 @RalfJung @bors @workingjubilee @taiki-e @cjgillot @rustbot