Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 7 pull requests #132972

Merged
merged 14 commits into from
Nov 13, 2024
Merged

Rollup of 7 pull requests #132972

merged 14 commits into from
Nov 13, 2024

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

chansuke and others added 14 commits November 10, 2024 22:24
CFI: Append debug location to CFI blocks

Currently we're not appending debug locations to the inserted CFI blocks. This shows up in rust-lang#132615 and rust-lang#100783. This change fixes that by passing down the debug location to the CFI type-test generation and appending it to the blocks.

Credits also belong to `@jakos-sec` who worked with me on this.
Update the doc comment of `ASCII_CASE_MASK`

Revived and continued the work from rust-lang#120282.

the original [branch](https://github.com/mahmudsudo/rust-1/tree/patch-1) was deleted, i created a new branch to carry the changes forward
…, r=Noratrieb

stabilize const_unicode_case_lookup

Fixes rust-lang#101400

See there for t-libs-api FCP
…ilee

Use GNU ld on m68k-unknown-linux-gnu

LLD does not really support the M68k architecture yet, specify `m68k-linux-gnu-ld` as the linker for the platform
…rs, r=saethlin

triagebot: add codegen reviewers

Discussed with `@saethlin` off-sides
stabilize const_option_ext

Fixes rust-lang#91930

FCP passed in that issue.
…tgross35

Add tracking issue number to unsigned_nonzero_div_ceil feature

Tracking issue: rust-lang#132968
@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself PG-exploit-mitigations Project group: Exploit mitigations S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Nov 12, 2024
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=7

@bors
Copy link
Contributor

bors commented Nov 12, 2024

📌 Commit d83de7e has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 12, 2024
@bors
Copy link
Contributor

bors commented Nov 13, 2024

⌛ Testing commit d83de7e with merge 242f20d...

@bors
Copy link
Contributor

bors commented Nov 13, 2024

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 242f20d to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 13, 2024
@bors bors merged commit 242f20d into rust-lang:master Nov 13, 2024
7 checks passed
@rustbot rustbot added this to the 1.84.0 milestone Nov 13, 2024
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#132702 CFI: Append debug location to CFI blocks 22347b8986c24960aca2bfdce7cef2a96e16c1f8 (link)
#132851 Update the doc comment of ASCII_CASE_MASK e9cebcb929e8f9ef1bf6a652f7eae202b4d6bc92 (link)
#132948 stabilize const_unicode_case_lookup 045faaa32ede582084b751da8130d1b3502aa42b (link)
#132950 Use GNU ld on m68k-unknown-linux-gnu 5fa3fccfafab663d6c76626ae3859f735170b398 (link)
#132962 triagebot: add codegen reviewers 4bda303614e8d1bd56dc78c96f6044397ea07a6f (link)
#132966 stabilize const_option_ext 05aa6d0cd83f5ba05a1dde512547a5bde9eccc77 (link)
#132970 Add tracking issue number to unsigned_nonzero_div_ceil feat… f40048f2586f0528c797fb03230a6bf03d5b97e7 (link)

previous master: b420d923cf

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (242f20d): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 1.8%, secondary 1.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
1.8% [0.9%, 2.8%] 3
Regressions ❌
(secondary)
1.7% [1.6%, 1.8%] 3
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 1.8% [0.9%, 2.8%] 3

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 784.61s -> 785.272s (0.08%)
Artifact size: 335.35 MiB -> 335.35 MiB (-0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself merged-by-bors This PR was explicitly merged by bors. PG-exploit-mitigations Project group: Exploit mitigations rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants