Rollup of 8 pull requests #136965

jhpratt · 2025-02-13T08:53:34Z

Successful merges:

Add cygwin target. #134999 (Add cygwin target.)
Resolve named regions when reporting type test failures in NLL #136559 (Resolve named regions when reporting type test failures in NLL)
Use a trait to enforce field validity for union fields + unsafe fields + unsafe<> binder types #136660 (Use a trait to enforce field validity for union fields + unsafe fields + unsafe<> binder types)
Parallel-compiler-related cleanup #136858 (Parallel-compiler-related cleanup)
cg_llvm: Reduce visibility of all functions in the llvm module #136881 (cg_llvm: Reduce visibility of all functions in the llvm module)
Always perform discr read for never pattern in EUV #136888 (Always perform discr read for never pattern in EUV)
Split out the extern_system_varargs feature #136948 (Split out the extern_system_varargs feature)
Fix import in bench for wasm #136949 (Fix import in bench for wasm)

r? @ghost
@rustbot modify labels: rollup

Co-authored-by: Ookiineko <[email protected]> Co-authored-by: nora <[email protected]> Co-authored-by: Jubilee <[email protected]>

…never called, so let's remove them

…Lock" parking_lot::RwLock doesn't have "impl Clone", so we should not have, either

It seems it is left-over after some refactoring

…tomicU64!

…seems they are left-over after my PR)

…Send"

…fe impl Sync"

This was unused after the removal of `-Zprofile` in rust-lang#131829.

…idity

After the stabilization PR was opened, `extern "system"` functions were added to `extended_varargs_abi_support`. This has a number of questions regarding it that were not discussed and were somewhat surprising. It deserves to be considered as its own feature, separate from `extended_varargs_abi_support`.

…=chenyukang,workingjubilee Add cygwin target. This PR simply adds cygwin target together with msys2 target, based on ````@ookiineko```` 's (the account has been deleted) [work](https://github.com/ookiineko-cygport/rust) on cygwin target. My full work is here: rust-lang/rust@master...Berrysoft:rust:dev/cygwin I have succeeded in building a new rustc for cygwin target, and eventually distributed a new version of [fish-shell](https://github.com/Berrysoft/fish-shell/releases) (rewritten by Rust) for MSYS2. I will open a new PR to fix std if this PR is accepted.

…r-type-test-failure, r=BoxyUwU Resolve named regions when reporting type test failures in NLL Just a improvement tweak to an error message that I broke out of a bigger PR that I had to close lol

…NoDrop, r=lcnr Use a trait to enforce field validity for union fields + `unsafe` fields + `unsafe<>` binder types This PR introduces a new, internal-only trait called `BikeshedGuaranteedNoDrop`[^1] to faithfully model the field check that used to be implemented manually by `allowed_union_or_unsafe_field`. https://github.com/rust-lang/rust/blob/942db6782f4a28c55b0b75b38fd4394d0483390f/compiler/rustc_hir_analysis/src/check/check.rs#L84-L115 Copying over the doc comment from the trait: ```rust /// Marker trait for the types that are allowed in union fields, unsafe fields, /// and unsafe binder types. /// /// Implemented for: /// * `&T`, `&mut T` for all `T`, /// * `ManuallyDrop<T>` for all `T`, /// * tuples and arrays whose elements implement `BikeshedGuaranteedNoDrop`, /// * or otherwise, all types that are `Copy`. /// /// Notably, this doesn't include all trivially-destructible types for semver /// reasons. /// /// Bikeshed name for now. ``` As far as I am aware, there's no new behavior being guaranteed by this trait, since it operates the same as the manually implemented check. We could easily rip out this trait and go back to using the manually implemented check for union fields, however using a trait means that this code can be shared by WF for `unsafe<>` binders too. See the last commit. The only diagnostic changes are that this now fires false-negatives for fields that are ill-formed. I don't consider that to be much of a problem though. r? oli-obk [^1]: Please let's not bikeshed this name lol. There's no good name for `ValidForUnsafeFieldsUnsafeBindersAndUnionFields`.

…2-11-07-54, r=SparrowLii Parallel-compiler-related cleanup Parallel-compiler-related cleanup I carefully split changes into commits. Commit messages are self-explanatory. Squashing is not recommended. cc "Parallel Rustc Front-end" rust-lang#113349 r? SparrowLii ``@rustbot`` label: +WG-compiler-parallel

cg_llvm: Reduce visibility of all functions in the llvm module Next part of rust-lang#135502 This reduces the visibility of all functions in the `llvm` module to `pub(crate)` and marks the `enzyme_ffi` modules with `#![expect(dead_code)]` (as previously discussed: <rust-lang#135502 (comment)>). r? ``@Zalathar``

…ieril Always perform discr read for never pattern in EUV Always perform a read of `!` discriminants to ensure that it's captured by closures in expr use visitor Fixes rust-lang#136852 r? Nadrieril or reassign

…stem-varargs, r=compiler-errors Split out the `extern_system_varargs` feature After the stabilization PR was opened, `extern "system"` functions were added to `extended_varargs_abi_support`. This has a number of questions regarding it that were not discussed and were somewhat surprising. It deserves to be considered as its own feature, separate from `extended_varargs_abi_support`. Tracking issue: - rust-lang#136946

Fix import in bench for wasm This import was causing annoying unused import errors when checking the standard library for some wasm targets. The problem is that everything here is disabled if it is wasm32, but this import wasn't cfg'd.

jhpratt · 2025-02-13T08:53:51Z

@bors r+ rollup=never p=5

bors · 2025-02-13T08:53:55Z

📌 Commit f9142b0 has been approved by jhpratt

It is now in the queue for this repository.

bors · 2025-02-13T11:45:18Z

⌛ Testing commit f9142b0 with merge 54cdc75...

bors · 2025-02-13T14:38:30Z

☀️ Test successful - checks-actions
Approved by: jhpratt
Pushing 54cdc75 to master...

rust-timer · 2025-02-13T14:40:59Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#134999	Add cygwin target.	`2fa1350ebb444f571e59c78211a6789896fd0d2a` (link)
#136559	Resolve named regions when reporting type test failures in …	`dca0348b90b8141ee3ff2c249aad49830f1f3c4a` (link)
#136660	Use a trait to enforce field validity for union fields + `u…	`4750ea82336c98ff6617e4f6978c54740babcd6c` (link)
#136858	Parallel-compiler-related cleanup	`2eb5e2b6b3f2bc0cf4f61e0fa9146941d46eb95c` (link)
#136881	cg_llvm: Reduce visibility of all functions in the llvm mod…	`064159aff17a56fa5e8871a92fad458784a026b1` (link)
#136888	Always perform discr read for never pattern in EUV	`dce784c8e8bd93244c8aae4c2c62329c8e515d68` (link)
#136948	Split out the `extern_system_varargs` feature	`4d37ccb56b0b52e9f85c195881e15c001ec9d5d6` (link)
#136949	Fix import in bench for wasm	`adaea75c479a9bda3303072548e03c7db167b41a` (link)

previous master: 3cb02729ab

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2025-02-13T15:56:11Z

Finished benchmarking commit (54cdc75): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.2%	[0.2%, 0.3%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.2%	[-0.2%, -0.2%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary 0.6%, secondary 3.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.6%	[0.6%, 0.6%]	1
Regressions ❌ (secondary)	3.1%	[1.6%, 4.7%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.6%	[0.6%, 0.6%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 789.524s -> 792.804s (0.42%)
Artifact size: 347.86 MiB -> 347.85 MiB (-0.00%)

Berrysoft and others added 30 commits February 10, 2025 17:13

Add cygwin target.

f94ada1

Co-authored-by: Ookiineko <[email protected]> Co-authored-by: nora <[email protected]> Co-authored-by: Jubilee <[email protected]>

Apply suggestions

33d0f38

Reformat files

8e5207e

compiler/rustc_data_structures/src/sync.rs: these RwLock methods are …

42ceb25

…never called, so let's remove them

compiler/rustc_data_structures/src/sync.rs: remove "impl Clone for Rw…

25b6761

…Lock" parking_lot::RwLock doesn't have "impl Clone", so we should not have, either

compiler/rustc_data_structures/src/sync.rs: delete MappedLockGuard

c9c7b44

It seems it is left-over after some refactoring

compiler/rustc_data_structures/src/sync.rs: delete Weak

8f684c9

compiler/rustc_data_structures/src/sync.rs: remove atomics, but not A…

4a2c7f4

…tomicU64!

compiler/rustc_data_structures/src/sync.rs: delete Sync and Send

d79f9ca

src/doc/rustc-dev-guide/src/parallel-rustc.md: remove Arc and Rc (it …

afa01c1

…seems they are left-over after my PR)

compiler/rustc_codegen_gcc/src/back/lto.rs: delete "unsafe impl Sync/…

851cc4b

…Send"

compiler/rustc_codegen_llvm/src/lib.rs: remove "unsafe impl Send/Sync"

51f49d8

compiler/rustc_data_structures/src/sync/worker_local.rs: delete "unsa…

0240690

…fe impl Sync"

config.example.toml: remove "parallel-compiler"

8506dd2

Always perform discr read for never pattern in EUV

ffefb13

Nits

5a76304

Fix import in bench for wasm

c917373

Improved named region errors

d1b35f9

Remove LLVMGetModuleContext

659e20f

This was unused after the removal of `-Zprofile` in rust-lang#131829.

cg_llvm: Reduce visibility of all functions in the llvm module

e7cef26

Use core stubs in some CMSE tests

c72d443

Implement and use BikeshedGuaranteedNoDrop for union/unsafe field val…

516afd5

…idity

Use BikeshedGuaranteedNotDrop in unsafe binder type WF too

d0564fd

Rollup merge of rust-lang#136559 - compiler-errors:resolve-regions-fo…

4e6605f

…r-type-test-failure, r=BoxyUwU Resolve named regions when reporting type test failures in NLL Just a improvement tweak to an error message that I broke out of a bigger PR that I had to close lol

Rollup merge of rust-lang#136888 - compiler-errors:never-read, r=Nadr…

6fbca25

…ieril Always perform discr read for never pattern in EUV Always perform a read of `!` discriminants to ensure that it's captured by closures in expr use visitor Fixes rust-lang#136852 r? Nadrieril or reassign

jhpratt added 2 commits February 13, 2025 03:53

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 13, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 13, 2025

bors merged commit 54cdc75 into rust-lang:master Feb 13, 2025
7 checks passed

rustbot added this to the 1.86.0 milestone Feb 13, 2025

bors mentioned this pull request Feb 13, 2025

Set both nuw and nsw in slice size calculation #136575

Merged

jhpratt deleted the rollup-bsnqvmf branch February 14, 2025 03:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 8 pull requests #136965

Rollup of 8 pull requests #136965

jhpratt commented Feb 13, 2025

jhpratt commented Feb 13, 2025

bors commented Feb 13, 2025

bors commented Feb 13, 2025

bors commented Feb 13, 2025

rust-timer commented Feb 13, 2025

rust-timer commented Feb 13, 2025

Rollup of 8 pull requests #136965

Rollup of 8 pull requests #136965

Conversation

jhpratt commented Feb 13, 2025

jhpratt commented Feb 13, 2025

bors commented Feb 13, 2025

bors commented Feb 13, 2025

bors commented Feb 13, 2025

rust-timer commented Feb 13, 2025

rust-timer commented Feb 13, 2025

Overall result: ❌✅ regressions and improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size