A few cleanups after the removal of cfg(not(parallel))
#137922
+61
−74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the removal of `cfg(parallel_compiler)`, these parameters are never considered unused.
rustbot
added
A-query-system
|
The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes. |
SparrowLii
reviewed
Mar 3, 2025
With the removal of `cfg(parallel_compiler)`, these are always shared references and `std::sync::OnceLock`.
|
Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
|
I have squished as much as possible without losing crucial information. Squashing any more would make the history needlessly confusing. I also noticed that Clippy needed to be adjusted, and that the |
|
Thanks! |
|
🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened. |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 3, 2025
A few cleanups after the removal of `cfg(not(parallel))` I noticed a few small things that are no longer needed after the removal of `cfg(not(parallel))` in rust-lang#132282. One of the later changes adjusts several imports, so viewing the changes individually is recommended. r? SparrowLii (or reroll)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a few small things that are no longer needed after the removal of
cfg(not(parallel))in #132282.One of the later changes adjusts several imports, so viewing the changes individually is recommended.
r? SparrowLii (or reroll)