rewrite optimize attribute to use new attribute parsing infrastructure
#138291
+1,961
−901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-attributes
|
☔ The latest upstream changes (presumably #138302) made this pull request unmergeable. Please resolve the merge conflicts. |
oli-obk
added
S-waiting-on-author
jdonszelmann
force-pushed
the
optimize-attr
branch
2 times, most recently
from
e69db9b to
85e98db
Compare
This comment has been minimized.
This comment has been minimized.
jdonszelmann
force-pushed
the
optimize-attr
branch
from
85e98db to
a3f8007
Compare
This comment has been minimized.
This comment has been minimized.
jdonszelmann
force-pushed
the
optimize-attr
branch
from
a3f8007 to
fec1be4
Compare
This comment has been minimized.
This comment has been minimized.
jdonszelmann
force-pushed
the
optimize-attr
branch
from
fec1be4 to
678729e
Compare
This comment has been minimized.
This comment has been minimized.
jdonszelmann
force-pushed
the
optimize-attr
branch
from
678729e to
ef0e757
Compare
|
☔ The latest upstream changes (presumably #142299) made this pull request unmergeable. Please resolve the merge conflicts. |
jdonszelmann
force-pushed
the
optimize-attr
branch
from
ef0e757 to
9464974
Compare
lint on duplicates during attribute parsing To do this we stuff them in the diagnostic context to be emitted after hir is constructed
jdonszelmann
force-pushed
the
optimize-attr
branch
from
9464974 to
12c7b72
Compare
This comment has been minimized.
This comment has been minimized.
jdonszelmann
force-pushed
the
optimize-attr
branch
from
12c7b72 to
dfe3c6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @oli-obk
I'm afraid we'll get quite a few of these PRs in the future. If we get a lot of trivial changes I'll start merging multiple into one PR. They should be easy to review :)
Waiting on #138165 first