-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Add LLDB providers for BTreeMap and BTreeSet #140130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ede1998
wants to merge
1
commit into
rust-lang:master
Choose a base branch
from
ede1998:add-lldb-btree-providers
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+165
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot has assigned @Mark-Simulacrum. Use |
This comment has been minimized.
This comment has been minimized.
687620b
to
950f608
Compare
@rustbot author |
Reminder, once the PR becomes ready for a review, use |
e792e29
to
bb58d72
Compare
This comment has been minimized.
This comment has been minimized.
bb58d72
to
f5148c7
Compare
f5148c7
to
53ef2e0
Compare
Some changes occurred in src/tools/compiletest cc @jieyouxu |
@rustbot ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-compiletest
Area: The compiletest test runner
A-testsuite
Area: The testsuite used to check the correctness of rustc
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #111868.
I'm unsure what the supported LLDB versions for
rust-lldb
are. I tested with LLDB 18 and 19 and it works with those but I know that it does not work with LLDB 14 which was picked by mycodelldb
extension for some reason (even though it packages LLDB 19).I also had to work around what seems like an LLDB bug to me. Otherwise, I'd have kept the code more similar to the GDB provider.
SBTarget.FindFirstType()
does not find the types that I'm searching for (LeafNode<i32, i32>*
):which prints
All in all, my experience with LLDB debug provider was very fiddly/they seem to break easily but I think it would be better to have
BTreeMap
/BTreeSet
providers than not have them.Getting to run the
debuginfo
tests was a pain too because of #126092 and errors withimport _lldb
(#123621).I ended up re-compling lldb from source against python 3.10 because the tests don't work if lldb is compiled against python 3.12.
Also, it seems like the tests are not run in CI? At least I had a test commit in the PR before to trigger a
debuginfo
test failure which I didn't see here in my PR.