coverage-dump: Resolve global file IDs to filenames #140251
Open
+684
−410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zalathar
added
the
A-code-coverage
|
r? @clubby789 rustbot has assigned @clubby789. Use |
rustbot
added
A-testsuite
|
These commits modify the If this was unintentional then you should revert the changes before this PR is merged. |
Zalathar
force-pushed
the
coverage-dump-path
branch
from
e2a47cd to
447d537
Compare
|
The bootstrap step additions look reasonable to me (aside from some minor notes) |
clubby789
reviewed
Apr 25, 2025
Zalathar
force-pushed
the
coverage-dump-path
branch
from
447d537 to
aca0f34
Compare
This also causes the coverage-dump unit tests to run in CI and `./x test` by default.
Actually printing the filenames is deferred to a subsequent commit that will simultaneously bless all affected tests.
Zalathar
force-pushed
the
coverage-dump-path
branch
from
aca0f34 to
c65fc17
Compare
|
Rebased, then addressed review feedback, and added some relevant FIXMEs and other comments (diff). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The coverage-dump tool, used by coverage tests, currently includes “global file ID” numbers in its dump output.
This PR adds support for parsing coverage filename information from LLVM assembly
.llfiles, and resolving those file IDs to the corresponding filename, for inclusion in dump output.This makes dump output more informative, especially for test cases involving multiple files, and will be important for testing expansion region support in the future.
The bootstrap changes don't necessarily have to land at the same time (e.g. they could be deferred to after the stage0 redesign if requested), but I would prefer to land them now if possible.