-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Stabilize feature result_flattening
#141072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Stabilize feature result_flattening
#141072
Conversation
This comment has been minimized.
This comment has been minimized.
Yes, FCP is necessary and will be done on this PR. There's nothing you need to do on that front. |
6fd9348
to
4c2d3bc
Compare
This comment has been minimized.
This comment has been minimized.
Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
#[unstable(feature = "result_flattening", issue = "70142")] | ||
#[rustc_const_unstable(feature = "result_flattening", issue = "70142")] | ||
#[stable(feature = "result_flattening", since = "CURRENT_RUSTC_VERSION")] | ||
#[rustc_allow_const_fn_unstable(const_precise_live_drops)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uses of this attribute should always be called out in the PR as they require special attention. However, this one should be fine, for the same reason as all the other rustc_allow_const_fn_unstable(const_precise_live_drops)
: if we change how const_precise_live_drops
works, we'll ensure it keeps accepting these cases.
Cc @rust-lang/wg-const-eval
@rfcbot merge |
Team member @Amanieu has proposed to merge this. The next step is review by the rest of the tagged team members: No concerns currently listed. Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
🔔 This is now entering its final comment period, as per the review above. 🔔 |
Stabilizes the
Result::flatten
methodImplementations
Result::flatten
: Add Result<Result<T, E>, E>::flatten -> Result<T, E> #70140const
Result::flatten
: make unstable Result::flatten a const fn #130692Stabilization process
result_flattening
) #70142