-
Notifications
You must be signed in to change notification settings - Fork 13.4k
feat: add const
support for float rounding methods
#141521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ruancomelli
wants to merge
18
commits into
rust-lang:master
Choose a base branch
from
ruancomelli:const-float-rounding
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+330
−117
Open
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
56ce2f3
test: add tests that we expect to pass when float rounding becomes const
ruancomelli 8de1103
feat: make float rounding methods `const`
ruancomelli 0b1d30e
fix: replace `rustc_allow_const_fn_unstable(core_intrinsics)` attribu…
ruancomelli ca8a8db
revert: undo update to `library/stdarch`
ruancomelli 1113a19
refactor: replace multiple `float_<mode>_intrinsic` rounding methods …
ruancomelli d1bb3f0
revert: undo changes to `rint` functions
ruancomelli b7fb0df
fix: add `#[cfg(not(bootstrap))]` to new const method tests
ruancomelli 0e24d5c
test: add extra sign tests to check `+0.0` and `-0.0`
ruancomelli 52ce976
revert: undo accidental changes to `round` docs
ruancomelli b186fd1
fix: gate `const` float round method behind `const_float_round_methods`
ruancomelli 0caa691
fix: remove unnecessary `#![feature(const_float_methods)]`
ruancomelli 74e3628
fix: remove unnecessary `#![feature(const_float_methods)]` [2]
ruancomelli 3af13ac
revert: undo changes to `tests/ui/consts/const-eval/float_methods.rs`
ruancomelli e257f2f
fix: adjust after rebase
ruancomelli ca73cae
test: fix float tests
ruancomelli f8930f4
test: add tests for `fract`
ruancomelli c24e404
chore: add commented-out `const_float_round_methods` feature gates to…
ruancomelli 85056fd
fix: adjust NaN when rounding floats
ruancomelli File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.