Unimplement unsized_locals #141811

mejrs · 2025-05-31T11:46:40Z

Tracking issue here: #111942

Note that this just removes the feature, not the implementation, and does not touch unsized_fn_params. This is because it is required to support Box<dyn FnOnce()>: FnOnce().

There may be more that should be removed (possibly in follow up prs)

the forget_unsized function and forget intrinsic.
the unsized_locals test directory; I've just fixed up the tests for now
various codegen support for unsized values and allocas

cc @JakobDegen @oli-obk @Noratrieb @programmerjake @bjorn3

@rustbot label F-unsized_locals

Fixes #79409

rustbot · 2025-05-31T11:46:45Z

r? @SparrowLii

rustbot has assigned @SparrowLii.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2025-05-31T11:46:47Z

The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes.

cc @BoxyUwU, @jieyouxu, @Kobzol

The Miri subtree was changed

cc @rust-lang/miri

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

This PR changes a file inside tests/crashes. If a crash was fixed, please move into the corresponding ui subdir and add 'Fixes #' to the PR description to autoclose the issue upon merge.

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo, @GuillaumeGomez

This PR changes MIR

cc @oli-obk, @RalfJung, @JakobDegen, @davidtwco, @vakaras

compiler/rustc_borrowck/src/type_check/mod.rs

@@ -1951,7 +1950,7 @@ impl<'a, 'tcx> TypeChecker<'a, 'tcx> {
                    );
                }

-                // When `unsized_fn_params` and `unsized_locals` are both not enabled,
+                // When `unsized_fn_params` is both not enabled,


RalfJung · 2025-05-31T21:02:56Z

Implements rust-lang/compiler-team#630

That's 2 years ago and so it's not indicative of the team position today. Some stuff happened since then since some people want to preserve the feature.

This will need a new MCP I think.

Noratrieb · 2025-05-31T21:25:12Z

I don't think anything changed about the biggest issues (MIR support being lacking), the unsoundness around alignment was just one small factor I'd say. No one has stepped up to actually resolve any of these issues in two years, which doesn't indicate a lot of interest in the feature to me. That said, if you think a re-MCP should be done, I'd be happy to help drafting that up (I imagine it would mostly just copy from the old MCP).
To me, two years is not that long in this case and I'm not aware of any significant changes in any area that would make the result different now (other than the one fix), so I don't think it warrants a new MCP.

RalfJung · 2025-06-01T06:32:01Z

The MIR representation of unsized locals still needs to be re-done from scratch, that is true.

Noratrieb · 2025-06-01T08:40:34Z

compiler/rustc_feature/src/removed.rs

@@ -247,6 +247,8 @@ declare_features! (
    /// Allows unnamed fields of struct and union type
    (removed, unnamed_fields, "1.83.0", Some(49804), Some("feature needs redesign")),
    (removed, unsafe_no_drop_flag, "1.0.0", None, None),
+    /// Allows unsized rvalues at arguments and parameters.
+    (removed, unsized_locals, "CURRENT_RUSTC_VERSION", Some(48055), Some("removed due to soundness issues; see https://github.com/rust-lang/rust/issues/111942")),


Suggested change

(removed, unsized_locals, "CURRENT_RUSTC_VERSION", Some(48055), Some("removed due to soundness issues; see https://github.com/rust-lang/rust/issues/111942")),

(removed, unsized_locals, "CURRENT_RUSTC_VERSION", Some(48055), Some("removed due to implementation concerns; see https://github.com/rust-lang/rust/issues/111942")),

As pointed out by Ralf, it should be sound, just not sufficiently implemented

Wait yeah, you should apply this change.

scottmcm · 2025-06-01T19:31:10Z

Note that this just removes the feature, not the implementation

Maybe a dumb question, but why not remove the implementation? If the implementation is going to be there anyway, feels like having the feature is fine.

(My preference would be to remove the implementation too.)

Noratrieb · 2025-06-01T19:34:41Z

The implementation should be removed too but not in this PR^^

src/tools/clippy/tests/ui/large_stack_frames.rs

SparrowLii · 2025-06-04T00:38:07Z

This change makes sense. I know little about unsized locals, so I'd like to have someone more experienced take a look.
r? compiler

compiler-errors · 2025-06-11T23:39:45Z

compiler/rustc_feature/src/removed.rs

@@ -247,6 +247,8 @@ declare_features! (
    /// Allows unnamed fields of struct and union type
    (removed, unnamed_fields, "1.83.0", Some(49804), Some("feature needs redesign")),
    (removed, unsafe_no_drop_flag, "1.0.0", None, None),
+    /// Allows unsized rvalues at arguments and parameters.
+    (removed, unsized_locals, "CURRENT_RUSTC_VERSION", Some(48055), Some("removed due to soundness issues; see https://github.com/rust-lang/rust/issues/111942")),


Wait yeah, you should apply this change.

compiler-errors · 2025-06-11T23:39:54Z

@bors r-

compiler-errors · 2025-06-11T23:39:57Z

r=me after

mejrs · 2025-06-11T23:52:21Z

@rustbot ready

compiler-errors · 2025-06-11T23:55:39Z

ty

@bors r+

bors · 2025-06-11T23:55:42Z

📌 Commit c821423 has been approved by compiler-errors

It is now in the queue for this repository.

mejrs · 2025-06-12T00:36:26Z

Woops lol. I'll bless it tomorrow.

compiler-errors · 2025-06-12T00:37:23Z

yeah, pls rebase

@bors r- delegate+

bors · 2025-06-12T00:37:28Z

✌️ @mejrs, you can now approve this pull request!

If @compiler-errors told you to "r=me" after making some further change, please make that change, then do @bors r=@compiler-errors

mejrs · 2025-06-13T08:30:50Z

@bors r=@compiler-errors

bors · 2025-06-13T08:30:52Z

📌 Commit c0e02e2 has been approved by compiler-errors

It is now in the queue for this repository.

rustbot assigned SparrowLii May 31, 2025

rustbot added the F-unsized_locals `#![feature(unsized_locals)]` label May 31, 2025

This comment has been minimized.

Sign in to view

mejrs force-pushed the bye_locals branch from 04a0064 to 04f59bc Compare May 31, 2025 12:58

This comment has been minimized.

Sign in to view

mejrs force-pushed the bye_locals branch from 04f59bc to 224a8f4 Compare May 31, 2025 16:14

This comment has been minimized.

Sign in to view

zachs18 reviewed May 31, 2025

View reviewed changes

compiler/rustc_borrowck/src/type_check/mod.rs Outdated

@@ -1951,7 +1950,7 @@ impl<'a, 'tcx> TypeChecker<'a, 'tcx> {

);

}

// When `unsized_fn_params` and `unsized_locals` are both not enabled,

// When `unsized_fn_params` is both not enabled,

This comment was marked as resolved.

Sign in to view

mejrs force-pushed the bye_locals branch from 224a8f4 to 3fdbc07 Compare May 31, 2025 19:23

This comment has been minimized.

Sign in to view

mejrs force-pushed the bye_locals branch 2 times, most recently from 50c26a1 to 8f1e09e Compare May 31, 2025 20:30

This comment has been minimized.

Sign in to view

mejrs force-pushed the bye_locals branch from 8f1e09e to 81b3273 Compare May 31, 2025 21:58

Noratrieb reviewed Jun 1, 2025

View reviewed changes

flip1995 reviewed Jun 2, 2025

View reviewed changes

src/tools/clippy/tests/ui/large_stack_frames.rs Outdated Show resolved Hide resolved

mejrs force-pushed the bye_locals branch from 81b3273 to 9376cd8 Compare June 3, 2025 10:59

rustbot assigned compiler-errors Jun 4, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 11, 2025

compiler-errors requested changes Jun 11, 2025

View reviewed changes

rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jun 11, 2025

bors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jun 11, 2025

mejrs force-pushed the bye_locals branch from 9376cd8 to c821423 Compare June 11, 2025 23:50

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 11, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 11, 2025

This comment has been minimized.

Sign in to view

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 12, 2025

mejrs force-pushed the bye_locals branch from c821423 to 8f0b4f3 Compare June 12, 2025 09:45

This comment has been minimized.

Sign in to view

mejrs force-pushed the bye_locals branch from 8f0b4f3 to a3853be Compare June 12, 2025 21:15

Unimplement unsized_locals

c0e02e2

mejrs force-pushed the bye_locals branch from a3853be to c0e02e2 Compare June 12, 2025 23:16

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 13, 2025

	(removed, unsized_locals, "CURRENT_RUSTC_VERSION", Some(48055), Some("removed due to soundness issues; see https://github.com/rust-lang/rust/issues/111942")),
	(removed, unsized_locals, "CURRENT_RUSTC_VERSION", Some(48055), Some("removed due to implementation concerns; see https://github.com/rust-lang/rust/issues/111942")),

Unimplement unsized_locals #141811

Are you sure you want to change the base?

Unimplement unsized_locals #141811

Uh oh!

Conversation

mejrs commented May 31, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented May 31, 2025

Uh oh!

rustbot commented May 31, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment was marked as resolved.

Uh oh!

This comment has been minimized.

RalfJung commented May 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

Noratrieb commented May 31, 2025

Uh oh!

RalfJung commented Jun 1, 2025

Uh oh!

Noratrieb Jun 1, 2025

Choose a reason for hiding this comment

Uh oh!

compiler-errors Jun 11, 2025

Choose a reason for hiding this comment

Uh oh!

scottmcm commented Jun 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Noratrieb commented Jun 1, 2025

Uh oh!

Uh oh!

SparrowLii commented Jun 4, 2025

Uh oh!

compiler-errors Jun 11, 2025

Choose a reason for hiding this comment

Uh oh!

compiler-errors commented Jun 11, 2025

Uh oh!

compiler-errors commented Jun 11, 2025

Uh oh!

mejrs commented Jun 11, 2025

Uh oh!

compiler-errors commented Jun 11, 2025

Uh oh!

bors commented Jun 11, 2025

Uh oh!

This comment has been minimized.

mejrs commented Jun 12, 2025

Uh oh!

compiler-errors commented Jun 12, 2025

Uh oh!

bors commented Jun 12, 2025

Uh oh!

This comment has been minimized.

mejrs commented Jun 13, 2025

Uh oh!

bors commented Jun 13, 2025

Uh oh!

Uh oh!

mejrs commented May 31, 2025 •

edited by rustbot

Loading

RalfJung commented May 31, 2025 •

edited

Loading

scottmcm commented Jun 1, 2025 •

edited

Loading