Skip to content

Update stdarch submodule #141964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 7, 2025
Merged

Update stdarch submodule #141964

merged 3 commits into from
Jun 7, 2025

Conversation

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Jun 3, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jun 3, 2025

⚠️ Warning ⚠️

  • Some commits in this PR modify submodules.

@rust-log-analyzer

This comment has been minimized.

@sayantn
Copy link
Contributor Author

sayantn commented Jun 3, 2025

cc @bjorn3 I guess.

@bjorn3
Copy link
Member

bjorn3 commented Jun 3, 2025

That is caused by rust-lang/stdarch#1807. You can try replacing the llvm.aarch64.neon.frintn.v string in compiler/rustc_codegen_cranelift/src/intrinsics/llvm_aarch64.rs with llvm.roundeven.v and likely move it to compiler/rustc_codegen_cranelift/src/intrinsics/llvm.rs.

 - remove unused `llvm.aarch64.neon.frintn` from cg_clif
@rustbot
Copy link
Collaborator

rustbot commented Jun 3, 2025

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

@rust-log-analyzer

This comment has been minimized.

@rustbot
Copy link
Collaborator

rustbot commented Jun 3, 2025

Portable SIMD is developed in its own repository. If possible, consider making this change to rust-lang/portable-simd instead.

cc @calebzulawski, @programmerjake

The Miri subtree was changed

cc @rust-lang/miri

@Amanieu Amanieu added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jun 4, 2025
@Amanieu
Copy link
Member

Amanieu commented Jun 4, 2025

@bors r+ rollup=never

@bors
Copy link
Collaborator

bors commented Jun 4, 2025

📌 Commit fbc15c1 has been approved by Amanieu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 4, 2025
@Amanieu
Copy link
Member

Amanieu commented Jun 4, 2025

Beta-nominating specifically for rust-lang/stdarch#1818: we want that to be backported to beta since we accidentally stabilized some f16 types and intrinsics in beta. However it's not strictly necessary if the FCP on #136306 passes before the release deadline since we would be stabilizing them in the next release anyways.

@adamgemmell
Copy link
Contributor

A minor correction in case it changes something - the f16 types were accidentally introduced originally as stable so those aren't a regression and are currently stable on the stable channel. The couple of f16 intrinsics stabilised are the beta regression.

@RalfJung
Copy link
Member

RalfJung commented Jun 7, 2025

@bors p=1
(blocks follow-up work)

@bors
Copy link
Collaborator

bors commented Jun 7, 2025

⌛ Testing commit fbc15c1 with merge 5e0bdaa...

@bors
Copy link
Collaborator

bors commented Jun 7, 2025

☀️ Test successful - checks-actions
Approved by: Amanieu
Pushing 5e0bdaa to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 7, 2025
@bors bors merged commit 5e0bdaa into rust-lang:master Jun 7, 2025
11 checks passed
@rustbot rustbot added this to the 1.89.0 milestone Jun 7, 2025
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
   Compiling glob-match v0.2.1
   Compiling ureq v3.0.8
   Compiling citool v0.1.0 (/home/runner/work/rust/rust/src/ci/citool)
    Finished `release` profile [optimized] target(s) in 46.03s
     Running `target/release/citool post-merge-report 321dde12528a6baf0990ec611d33122b68c33fca 5e0bdaa9dde845b8e44fd93bf0c09d21ca60daa1`
Downloading metrics of job aarch64-gnu
Downloading metrics of job aarch64-gnu-debug
Downloading metrics of job arm-android
Downloading metrics of job armhf-gnu
Downloading metrics of job dist-aarch64-linux
Downloading metrics of job dist-android
Downloading metrics of job dist-arm-linux-gnueabi
Downloading metrics of job dist-arm-linux-musl
Downloading metrics of job dist-armhf-linux
Downloading metrics of job dist-armv7-linux
Downloading metrics of job dist-i586-gnu-i586-i686-musl
Downloading metrics of job dist-i686-linux
Downloading metrics of job dist-loongarch64-linux
Downloading metrics of job dist-loongarch64-musl
Downloading metrics of job dist-ohos-aarch64
Downloading metrics of job dist-ohos-armv7
Downloading metrics of job dist-ohos-x86_64
Downloading metrics of job dist-powerpc-linux
Downloading metrics of job dist-powerpc64-linux
Downloading metrics of job dist-powerpc64le-linux-gnu
Downloading metrics of job dist-powerpc64le-linux-musl
Downloading metrics of job dist-riscv64-linux
Downloading metrics of job dist-s390x-linux
Downloading metrics of job dist-various-1
Downloading metrics of job dist-various-2
Downloading metrics of job dist-x86_64-freebsd
Downloading metrics of job dist-x86_64-illumos
Downloading metrics of job dist-x86_64-linux
Downloading metrics of job dist-x86_64-linux-alt
Downloading metrics of job dist-x86_64-musl
Downloading metrics of job dist-x86_64-netbsd
Downloading metrics of job dist-x86_64-solaris
Downloading metrics of job dist-sparcv9-solaris
Downloading metrics of job i686-gnu-1
Downloading metrics of job i686-gnu-2
Downloading metrics of job i686-gnu-nopt-1
Downloading metrics of job i686-gnu-nopt-2
Downloading metrics of job mingw-check-1
Downloading metrics of job mingw-check-2
Downloading metrics of job test-various
Downloading metrics of job x86_64-rust-for-linux
Downloading metrics of job x86_64-gnu
Downloading metrics of job x86_64-gnu-stable
Downloading metrics of job x86_64-gnu-aux
Downloading metrics of job x86_64-gnu-debug
Downloading metrics of job x86_64-gnu-distcheck
Downloading metrics of job x86_64-gnu-llvm-20-1
Downloading metrics of job x86_64-gnu-llvm-20-2
Downloading metrics of job x86_64-gnu-llvm-20-3
Downloading metrics of job x86_64-gnu-llvm-19-1
Downloading metrics of job x86_64-gnu-llvm-19-2
Downloading metrics of job x86_64-gnu-llvm-19-3
Downloading metrics of job x86_64-gnu-nopt
Downloading metrics of job x86_64-gnu-tools
Downloading metrics of job dist-x86_64-apple
Downloading metrics of job dist-apple-various
Downloading metrics of job x86_64-apple-1
Error: timeout: global
##[error]Process completed with exit code 1.
Post job cleanup.

@RalfJung
Copy link
Member

RalfJung commented Jun 7, 2025

@rust-lang/infra there's a strange post-merge CI failure here, or something like that?

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (5e0bdaa): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 1.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
1.3% [1.3%, 1.3%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 1.3% [1.3%, 1.3%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 752.134s -> 753.141s (0.13%)
Artifact size: 372.51 MiB -> 372.46 MiB (-0.01%)

@Kobzol
Copy link
Contributor

Kobzol commented Jun 7, 2025

Seems like a spurious timeout.

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 8, 2025
…r=bjorn3

Atomic intrinsics : use const generic ordering, part 2

This completes what got started in rust-lang#141507 by using a const generic for the ordering for all intrinsics. It is based on that PR; only the last commit is new.

Blocked on:
- rust-lang#141507
- rust-lang#141687
- rust-lang/stdarch#1811
- rust-lang#141964

r? `@bjorn3`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta-nominated Nominated for backporting to the compiler in the beta channel. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracking Issue for AVX512 intrinsics
10 participants