Rework #[cold] attribute parser

[jdonszelmann]

r? @ghost

NOTE: blocked by #138165

[rust-log-analyzer]

The job x86_64-gnu-llvm-19 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

#18 exporting to docker image format
#18 sending tarball 26.4s done
#18 DONE 39.5s
##[endgroup]
Setting extra environment values for docker:  --env ENABLE_GCC_CODEGEN=1 --env GCC_EXEC_PREFIX=/usr/lib/gcc/
[CI_JOB_NAME=x86_64-gnu-llvm-19]
[CI_JOB_NAME=x86_64-gnu-llvm-19]
debug: `DISABLE_CI_RUSTC_IF_INCOMPATIBLE` configured.
---
sccache: Listening on address 127.0.0.1:4226
##[group]Configure the build
configure: processing command line
configure: 
configure: build.configure-args := ['--build=x86_64-unknown-linux-gnu', '--llvm-root=/usr/lib/llvm-19', '--enable-llvm-link-shared', '--set', 'rust.randomize-layout=true', '--set', 'rust.thin-lto-import-instr-limit=10', '--set', 'build.print-step-timings', '--enable-verbose-tests', '--set', 'build.metrics', '--enable-verbose-configure', '--enable-sccache', '--disable-manage-submodules', '--enable-locked-deps', '--enable-cargo-native-static', '--set', 'rust.codegen-units-std=1', '--set', 'dist.compression-profile=balanced', '--dist-compression-formats=xz', '--set', 'rust.lld=false', '--disable-dist-src', '--release-channel=nightly', '--enable-debug-assertions', '--enable-overflow-checks', '--enable-llvm-assertions', '--set', 'rust.verify-llvm-ir', '--set', 'rust.codegen-backends=llvm,cranelift,gcc', '--set', 'llvm.static-libstdcpp', '--set', 'gcc.download-ci-gcc=true', '--enable-new-symbol-mangling']
configure: build.build          := x86_64-unknown-linux-gnu
configure: target.x86_64-unknown-linux-gnu.llvm-config := /usr/lib/llvm-19/bin/llvm-config
configure: llvm.link-shared     := True
configure: rust.randomize-layout := True
configure: rust.thin-lto-import-instr-limit := 10
---
   Compiling rustc_parse v0.0.0 (/checkout/compiler/rustc_parse)
error[E0061]: this function takes 4 arguments but 3 arguments were supplied
   --> compiler/rustc_attr_parsing/src/attributes/stability.rs:372:36
    |
372 |             Some(sym::old_name) => insert_value_into_option_or_error(cx, &param, &mut old_name)?,
    |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^--------------------------- argument #4 of type `rustc_span::Ident` is missing
    |
note: function defined here
   --> compiler/rustc_attr_parsing/src/attributes/stability.rs:216:4
    |
216 | fn insert_value_into_option_or_error<S: Stage>(
    |    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
...
220 |     name: Ident,
    |     -----------
help: provide the argument
    |
372 |             Some(sym::old_name) => insert_value_into_option_or_error(cx, &param, &mut old_name, /* rustc_span::Ident */)?,
    |                                                                                               +++++++++++++++++++++++++

For more information about this error, try `rustc --explain E0061`.
[RUSTC-TIMING] rustc_attr_parsing test:false 0.513
error: could not compile `rustc_attr_parsing` (lib) due to 1 previous error