Re-disable tests/run-make/short-ice on Windows MSVC again
#143199
+6
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rustbot has assigned @Mark-Simulacrum. Use |
rustbot
added
A-run-make
|
Thanks! @bors r+ rollup |
bors
added
S-waiting-on-bors
|
Let me fix my comment actually, one sec |
bors
added
S-waiting-on-author
|
Fixed comment to say it's not that there's no short backtrace markers, but that there is a mismatch. @bors r=RalfJung |
bors
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jun 29, 2025
Re-disable `tests/run-make/short-ice` on Windows MSVC again We tried to re-enable this for MSVC in rust-lang#142844. Unfortunately, this test still sometimes fails on Windows MSVC. Tracked in rust-lang#143198. FYI `@dpaoliello` (I couldn't reproduce this easily locally either)
bors
added a commit
that referenced
this pull request
Jun 29, 2025
Rollup of 7 pull requests Successful merges: - #142429 (`tests/ui`: A New Order [13/N]) - #143066 (Use let chains in the new solver) - #143156 (inherit `#[align]` from trait method prototypes) - #143176 (fix typos and improve clarity in documentation) - #143187 (Add my work email to mailmap) - #143194 (fix bitcast of single-element SIMD vectors) - #143199 (Re-disable `tests/run-make/short-ice` on Windows MSVC again) r? `@ghost` `@rustbot` modify labels: rollup
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jun 30, 2025
Re-disable `tests/run-make/short-ice` on Windows MSVC again We tried to re-enable this for MSVC in rust-lang#142844. Unfortunately, this test still sometimes fails on Windows MSVC. Tracked in rust-lang#143198. FYI ``@dpaoliello`` (I couldn't reproduce this easily locally either)
bors
added a commit
that referenced
this pull request
Jun 30, 2025
Rollup of 7 pull requests Successful merges: - #142429 (`tests/ui`: A New Order [13/N]) - #143066 (Use let chains in the new solver) - #143156 (inherit `#[align]` from trait method prototypes) - #143176 (fix typos and improve clarity in documentation) - #143187 (Add my work email to mailmap) - #143199 (Re-disable `tests/run-make/short-ice` on Windows MSVC again) - #143219 (Show auto trait and blanket impls for `!`) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We tried to re-enable this for MSVC in #142844.
Unfortunately, this test still sometimes fails on Windows MSVC.
Tracked in #143198.
FYI @dpaoliello (I couldn't reproduce this easily locally either)