Skip to content

Port streaming commands in bootstrap to BootstrapCommand and remove as_command_mut #143354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 6, 2025

Conversation

Shourya742
Copy link
Contributor

This PR adds streaming capabilities to BootstrapCommand and migrate existing command streaming scenario's used in bootstrap.

r? @Kobzol

@rustbot rustbot added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Jul 3, 2025
@rust-log-analyzer

This comment has been minimized.

Copy link
Member

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Left a few comments.

@Shourya742 Shourya742 force-pushed the 2025-07-03-bye-bye-as_mut-command branch from 57f20c5 to 868ef64 Compare July 4, 2025 12:49
@rust-log-analyzer

This comment has been minimized.

@Shourya742 Shourya742 marked this pull request as ready for review July 4, 2025 15:25
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 4, 2025
@rust-log-analyzer

This comment has been minimized.

@Shourya742 Shourya742 force-pushed the 2025-07-03-bye-bye-as_mut-command branch from 64ac851 to 03c7625 Compare July 4, 2025 16:03
@Kobzol Kobzol changed the title Bye bye as command mut Port streaming commands in bootstrap to BootstrapCommand and remove as_command_mut Jul 4, 2025
@Shourya742 Shourya742 force-pushed the 2025-07-03-bye-bye-as_mut-command branch 2 times, most recently from ee110a1 to 216ef55 Compare July 5, 2025 05:58
@Shourya742 Shourya742 force-pushed the 2025-07-03-bye-bye-as_mut-command branch from 216ef55 to c4fae7c Compare July 5, 2025 06:03
@rust-log-analyzer

This comment has been minimized.

@Shourya742 Shourya742 force-pushed the 2025-07-03-bye-bye-as_mut-command branch from c4fae7c to 536d15a Compare July 5, 2025 06:36
@Shourya742 Shourya742 requested a review from Kobzol July 5, 2025 09:34
@Kobzol
Copy link
Member

Kobzol commented Jul 5, 2025

#143354 (comment) :)

@Shourya742 Shourya742 force-pushed the 2025-07-03-bye-bye-as_mut-command branch from 536d15a to 312de35 Compare July 5, 2025 18:41
@Kobzol
Copy link
Member

Kobzol commented Jul 5, 2025

Thanks!

@bors r+ rollup=iffy

@bors
Copy link
Collaborator

bors commented Jul 5, 2025

📌 Commit 312de35 has been approved by Kobzol

It is now in the queue for this repository.

@bors bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 5, 2025
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jul 5, 2025
@bors
Copy link
Collaborator

bors commented Jul 6, 2025

⌛ Testing commit 312de35 with merge e804cd4...

@bors
Copy link
Collaborator

bors commented Jul 6, 2025

☀️ Test successful - checks-actions
Approved by: Kobzol
Pushing e804cd4 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 6, 2025
@bors bors merged commit e804cd4 into rust-lang:master Jul 6, 2025
12 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jul 6, 2025
Copy link
Contributor

github-actions bot commented Jul 6, 2025

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing febb10d (parent) -> e804cd4 (this PR)

Test differences

Show 4 test diffs

4 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard e804cd4a5f1a5b658ddca245c80bef96a576c018 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-apple-2: 5488.2s -> 3965.9s (-27.7%)
  2. i686-gnu-2: 6009.0s -> 5169.6s (-14.0%)
  3. dist-x86_64-apple: 8322.1s -> 9367.2s (12.6%)
  4. tidy: 67.6s -> 75.6s (12.0%)
  5. i686-gnu-nopt-1: 7945.2s -> 7058.9s (-11.2%)
  6. armhf-gnu: 5357.2s -> 4815.1s (-10.1%)
  7. pr-check-1: 1762.7s -> 1587.7s (-9.9%)
  8. dist-ohos-armv7: 3841.8s -> 4218.3s (9.8%)
  9. x86_64-gnu-debug: 5933.1s -> 5380.1s (-9.3%)
  10. x86_64-gnu-llvm-19-1: 3568.7s -> 3236.2s (-9.3%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (e804cd4): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.0% [0.0%, 0.0%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.4% [-0.5%, -0.3%] 2
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary -0.4%, secondary 2.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
0.8% [0.8%, 0.8%] 1
Regressions ❌
(secondary)
2.0% [2.0%, 2.0%] 1
Improvements ✅
(primary)
-1.7% [-1.7%, -1.7%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -0.4% [-1.7%, 0.8%] 2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 460.756s -> 462.855s (0.46%)
Artifact size: 372.14 MiB -> 372.14 MiB (-0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants