Shows a user friendly message rather than simple pass #143485
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shows user-friendly message guiding them on how to install Python 3 and offers OS-specific tips
|
rustbot has assigned @Mark-Simulacrum. Use |
rustbot
added
S-waiting-on-review
fmease
reviewed
Jul 5, 2025
Comment on lines
+29
to
+30
| print("Python 3 is not available. Please install Python 3.6 or later.") | ||
| sys.exit(1) |
There was a problem hiding this comment.
Doesn't this break Python 2 users (who don't have Python 3 installed on their system)? We intentionally keep supporting Python 2 past EOL because it doesn't cost us much maintenance-wise. The pass is quite intentional here.
There was a problem hiding this comment.
Absolutely you are right, but mentioning the print mostly refers to user get right kind of version which will eventually help them task done..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shows user-friendly message guiding them on how to install Python 3 and offers OS-specific tips