-
Notifications
You must be signed in to change notification settings - Fork 13.5k
Rollup of 6 pull requests #143507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 6 pull requests #143507
Conversation
Synced rust-analyzer configs
Automatic Rustup
make ./miri work on stable again
also test on arm-64 linux hosts
Various platforms provide a function to return the current OS thread ID, but they all use a slightly different name. Add shims for these functions for Apple, FreeBSD, and Windows, with tests to account for those and a few more platforms that are not yet supported by Miri. The syscall and extern symbol is included as well on Linux. These should be useful in general but will also help support printing the OS thread ID in panic messages [1]. [1]: rust-lang#115746 Squashed commit from Ralf: try_from_scalar: extend comment
run CI on a bunch more architectures
Add shims for `gettid`-esque functions
linux futex: fix for val > i32::MAX
Automatic Rustup
./miri toolchain: no need to run 'cargo metadata'
re-balance CI jobs
@bors +r rollup=never p=5 |
@bors r+ rollup=never p=5 |
Rollup of 6 pull requests Successful merges: - #143238 (Port `#[ignore]` to the new attribute parsing infrastructure) - #143441 (Stop using `Key` trait unnecessarily) - #143478 (Miri subtree update) - #143486 (remove armv5te-unknown-linux-gnueabi target maintainer) - #143489 (Complete rustc_ast::mut_visit for spans.) - #143494 (Remove yields_in_scope from the scope tree.) r? `@ghost` `@rustbot` modify labels: rollup
The job Click to see the possible cause of the failure (guessed by this bot)
|
💔 Test failed - checks-actions |
@bors retry |
☀️ Test successful - checks-actions |
📌 Perf builds for each rolled up PR:
previous master: 75d5834a6c In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 75d5834 (parent) -> febb10d (this PR) Test differencesShow 14 test diffsStage 2
Additionally, 13 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard febb10d0a2d29278135676783f6a22eb83295981 --output-dir test-dashboard And then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Finished benchmarking commit (febb10d): comparison URL. Overall result: ❌✅ regressions and improvements - please read the text belowOur benchmarks found a performance regression caused by this PR. Next Steps:
@rustbot label: +perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 0.8%, secondary 4.8%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary 2.2%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 162.322s -> 460.756s (183.85%) |
The bootstrap result is a fluke, caused by a weird result from the previous merge PR. |
Successful merges:
#[ignore]
to the new attribute parsing infrastructure #143238 (Port#[ignore]
to the new attribute parsing infrastructure)Key
trait unnecessarily #143441 (Stop usingKey
trait unnecessarily)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup