Skip to content

Rollup of 6 pull requests #143507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 70 commits into from
Jul 6, 2025
Merged

Rollup of 6 pull requests #143507

merged 70 commits into from
Jul 6, 2025

Conversation

matthiaskrgr
Copy link
Member

@matthiaskrgr matthiaskrgr commented Jul 5, 2025

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

YohDeadfall and others added 30 commits June 28, 2025 23:35
Various platforms provide a function to return the current OS thread ID,
but they all use a slightly different name. Add shims for these
functions for Apple, FreeBSD, and Windows, with tests to account for
those and a few more platforms that are not yet supported by Miri. The
syscall and extern symbol is included as well on Linux.

These should be useful in general but will also help support printing
the OS thread ID in panic messages [1].

[1]: rust-lang#115746

Squashed commit from Ralf:

    try_from_scalar: extend comment
run CI on a bunch more architectures
Add shims for `gettid`-esque functions
./miri toolchain: no need to run 'cargo metadata'
@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Jul 5, 2025
@matthiaskrgr
Copy link
Member Author

@bors +r rollup=never p=5

@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=5

@bors
Copy link
Collaborator

bors commented Jul 5, 2025

📌 Commit c3c4fd7 has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 5, 2025
@bors
Copy link
Collaborator

bors commented Jul 5, 2025

⌛ Testing commit c3c4fd7 with merge b7b5409...

bors added a commit that referenced this pull request Jul 5, 2025
Rollup of 6 pull requests

Successful merges:

 - #143238 (Port `#[ignore]` to the new attribute parsing infrastructure)
 - #143441 (Stop using `Key` trait unnecessarily)
 - #143478 (Miri subtree update)
 - #143486 (remove armv5te-unknown-linux-gnueabi target maintainer)
 - #143489 (Complete rustc_ast::mut_visit for spans.)
 - #143494 (Remove yields_in_scope from the scope tree.)

r? `@ghost`
`@rustbot` modify labels: rollup
@rust-log-analyzer
Copy link
Collaborator

The job test-various failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@bors
Copy link
Collaborator

bors commented Jul 6, 2025

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 6, 2025
@matthiaskrgr
Copy link
Member Author

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 6, 2025
@bors
Copy link
Collaborator

bors commented Jul 6, 2025

⌛ Testing commit c3c4fd7 with merge febb10d...

@bors
Copy link
Collaborator

bors commented Jul 6, 2025

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing febb10d to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 6, 2025
@bors bors merged commit febb10d into rust-lang:master Jul 6, 2025
1 check passed
@rustbot rustbot added this to the 1.90.0 milestone Jul 6, 2025
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#143238 Port #[ignore] to the new attribute parsing infrastructure e8dc3199bd49cc4c23d096215421216754c1a029 (link)
#143441 Stop using Key trait unnecessarily b44d4bad29f7d4b5fbccc1b7200a63ceae91e95d (link)
#143478 Miri subtree update e2e0f873da699c8bca0eabf203ade9b866dde8ad (link)
#143486 remove armv5te-unknown-linux-gnueabi target maintainer 53d64c709fb433899b8cb8face425aa4f26646e8 (link)
#143489 Complete rustc_ast::mut_visit for spans. c32a8eaf13d83793f65d8e4cb4c947e058d8b2dd (link)
#143494 Remove yields_in_scope from the scope tree. b586c7ac84b72ca5ffef5bc5b553bd1c9fce3955 (link)

previous master: 75d5834a6c

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

Copy link
Contributor

github-actions bot commented Jul 6, 2025

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 75d5834 (parent) -> febb10d (this PR)

Test differences

Show 14 test diffs

Stage 2

  • [run-make] tests/run-make/compressed-debuginfo-zstd: ignore (ignored if LLVM wasn't build with zstd for ELF section compression (we want LLVM/LLD to be built with zstd support)) -> pass (J0)

Additionally, 13 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard febb10d0a2d29278135676783f6a22eb83295981 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. aarch64-apple: 9092.6s -> 4458.1s (-51.0%)
  2. x86_64-apple-2: 7679.9s -> 5488.2s (-28.5%)
  3. x86_64-rust-for-linux: 3892.2s -> 2854.2s (-26.7%)
  4. pr-check-2: 2670.2s -> 2006.0s (-24.9%)
  5. x86_64-apple-1: 10384.9s -> 7834.3s (-24.6%)
  6. pr-check-1: 2327.7s -> 1762.7s (-24.3%)
  7. x86_64-gnu-tools: 4749.1s -> 3648.2s (-23.2%)
  8. dist-apple-various: 7227.4s -> 5586.0s (-22.7%)
  9. arm-android: 7518.9s -> 6131.6s (-18.5%)
  10. armhf-gnu: 6487.3s -> 5357.2s (-17.4%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (febb10d): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

  • If the regression was expected or you think it can be justified,
    please write a comment with sufficient written justification, and add
    @rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
  • If you think that you know of a way to resolve the regression, try to create
    a new PR with a fix for the regression.
  • If you do not understand the regression or you think that it is just noise,
    you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
    were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.2% [0.2%, 0.3%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.7% [-1.4%, -0.2%] 8
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary 0.8%, secondary 4.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
1.4% [1.2%, 1.5%] 3
Regressions ❌
(secondary)
4.8% [4.8%, 4.8%] 1
Improvements ✅
(primary)
-0.8% [-0.8%, -0.8%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.8% [-0.8%, 1.5%] 4

Cycles

Results (primary 2.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
2.2% [2.0%, 2.4%] 3
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 2.2% [2.0%, 2.4%] 3

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 162.322s -> 460.756s (183.85%)
Artifact size: 372.06 MiB -> 372.14 MiB (0.02%)

@rustbot rustbot added the perf-regression Performance regression. label Jul 6, 2025
@Kobzol
Copy link
Member

Kobzol commented Jul 6, 2025

The bootstrap result is a fluke, caused by a weird result from the previous merge PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-attributes Area: Attributes (`#[…]`, `#![…]`) merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.