Skip to content

Constify some more Result functions #143771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 3, 2025
Merged

Constify some more Result functions #143771

merged 1 commit into from
Aug 3, 2025
+197 −25

Conversation

Randl
Copy link
Contributor

@Randl Randl commented Jul 11, 2025

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Jul 11, 2025

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 11, 2025
tgross35
tgross35 reviewed Jul 11, 2025
View reviewed changes
@tgross35
Copy link
Contributor

Cc @rust-lang/wg-const-eval @rust-lang/libs-api, there is a lot here. Are we in "constify everything" mode, or what is a reasonable level of discretion?

@oli-obk oli-obk changed the title Constify some more Result funstions Constify some more Result functions Jul 11, 2025
@oli-obk
Copy link
Contributor

oli-obk commented Jul 11, 2025 •
edited
Loading

We are in "constifying everything mode", yes

RalfJung
RalfJung reviewed Jul 11, 2025
View reviewed changes
RalfJung
RalfJung reviewed Jul 11, 2025
View reviewed changes
@lcnr
Copy link
Contributor

lcnr commented Jul 11, 2025

Have we decided on the const Trait bound syntax again and what's the current rustdoc output for these 🤔 Haven't followed the recent progress here and want to be sure we don't partially constify std only to have to change it again in the future

@oli-obk
Copy link
Contributor

oli-obk commented Jul 11, 2025 •
edited
Loading

Have we decided on the const Trait bound syntax again and what's the current rustdoc output for these 🤔 Haven't followed the recent progress here and want to be sure we don't partially constify std only to have to change it again in the future

we're in a chicken-egg situation: T-lang wants hands on experience with this syntax (well [const], but that will automatically happen via rustfmt on the next beta bump). But without that experience we won't get a final decision.

So no real decision yet, but also not as much trouble as it was considering we don't need to cfg(bootstrap) libcore anymore

oli-obk
oli-obk reviewed Jul 11, 2025
View reviewed changes
tgross35
tgross35 reviewed Jul 11, 2025
View reviewed changes
tgross35
tgross35 reviewed Jul 11, 2025
View reviewed changes
@tgross35
Copy link
Contributor

After updating the feature gate and tracking issue, I think this will be pretty good. Please squash with a reasonable commit message.

@tgross35
Copy link
Contributor

@rustbot author

@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 18, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jul 18, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@rustbot rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jul 18, 2025
@Randl Randl mentioned this pull request Jul 20, 2025
Open
3 tasks
@Randl
Copy link
Contributor Author

Randl commented Jul 20, 2025

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 20, 2025
@Randl Randl requested a review from tgross35 July 29, 2025 05:03
tgross35
tgross35 approved these changes Aug 1, 2025
View reviewed changes
Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One request above then lgtm from a libs perspective. Typically libs-api needs to give the okay for unstable user-visible changes, but per #144289 (comment) traits are wg-const-eval. So for the API changes:

r? @rust-lang/wg-const-eval

@rustbot rustbot assigned RalfJung and unassigned tgross35 Aug 1, 2025
@RalfJung
Copy link
Member

RalfJung commented Aug 1, 2025

I'm heading out for vacation soon so won't have time to review this for a while. Also I haven't been following const-traits much, that was mostly @oli-obk (also on vacation) and @fee1-dead.

@tgross35 I'm entirely fine with you landing this if you're happy with it, given it's all unstable.

@tgross35
Copy link
Contributor

tgross35 commented Aug 1, 2025

That works for me, enjoy the 🌴

Thank you for putting this together @Randl!

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 1, 2025

📌 Commit 9377e0a has been approved by tgross35

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 1, 2025
samueltardieu added a commit to samueltardieu/rust that referenced this pull request Aug 2, 2025
@samueltardieu
Rollup merge of rust-lang#143771 - Randl:const-result, r=tgross35
9d089e3 
Constify some more `Result` functions
@samueltardieu samueltardieu mentioned this pull request Aug 2, 2025
Closed
bors added a commit that referenced this pull request Aug 2, 2025
@bors
Auto merge of #144810 - samueltardieu:rollup-ytnjvge, r=samueltardieu
5a23cc7 
Rollup of 18 pull requests

Successful merges:

 - #132748 (get rid of some false negatives in rustdoc::broken_intra_doc_links)
 - #135771 ([rustdoc] Add support for associated items in "jump to def" feature)
 - #143360 (loop match: error on `#[const_continue]` outside `#[loop_match]`)
 - #143662 ([rustdoc] Display unsafe attrs with edition 2024 `unsafe()` wrappers.)
 - #143771 (Constify some more `Result` functions)
 - #143900 ([rustdoc] Correctly handle `should_panic` doctest attribute and fix `--no-run` test flag on the 2024 edition)
 - #144185 (Document guarantees of poisoning)
 - #144395 (update fortanix tests)
 - #144478 (Improve formatting of doc code blocks)
 - #144614 (Fortify RemoveUnneededDrops test.)
 - #144703 ([test][AIX] ignore extern_weak linkage test)
 - #144747 (compiletest: Improve diagnostics for line annotation mismatches 2)
 - #144756 (detect infinite recursion with tail calls in ctfe)
 - #144766 (Add human readable name "Cygwin")
 - #144782 (Properly pass path to staged `rustc` to `compiletest` self-tests)
 - #144786 (Cleanup the definition of `group_type`)
 - #144796 (Add my previous commit name to .mailmap)
 - #144797 (Update safety comment for new_unchecked in niche_types)

Failed merges:

 - #144805 (compiletest: Preliminary cleanup of `ProcRes` printing/unwinding)

r? `@ghost`
`@rustbot` modify labels: rollup
@samueltardieu samueltardieu mentioned this pull request Aug 2, 2025
Merged
bors added a commit that referenced this pull request Aug 2, 2025
@bors
Auto merge of #144814 - samueltardieu:rollup-qyum1hj, r=samueltardieu
5b9564a 
Rollup of 17 pull requests

Successful merges:

 - #132748 (get rid of some false negatives in rustdoc::broken_intra_doc_links)
 - #143360 (loop match: error on `#[const_continue]` outside `#[loop_match]`)
 - #143662 ([rustdoc] Display unsafe attrs with edition 2024 `unsafe()` wrappers.)
 - #143771 (Constify some more `Result` functions)
 - #144185 (Document guarantees of poisoning)
 - #144395 (update fortanix tests)
 - #144478 (Improve formatting of doc code blocks)
 - #144614 (Fortify RemoveUnneededDrops test.)
 - #144703 ([test][AIX] ignore extern_weak linkage test)
 - #144747 (compiletest: Improve diagnostics for line annotation mismatches 2)
 - #144756 (detect infinite recursion with tail calls in ctfe)
 - #144766 (Add human readable name "Cygwin")
 - #144782 (Properly pass path to staged `rustc` to `compiletest` self-tests)
 - #144786 (Cleanup the definition of `group_type`)
 - #144796 (Add my previous commit name to .mailmap)
 - #144797 (Update safety comment for new_unchecked in niche_types)
 - #144803 (rustc-dev-guide subtree update)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 96b3b83 into rust-lang:master Aug 3, 2025
10 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Aug 3, 2025
rust-timer added a commit that referenced this pull request Aug 3, 2025
@rust-timer
Unrolled build for #143771
6961728 
Rollup merge of #143771 - Randl:const-result, r=tgross35

Constify some more `Result` functions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RalfJung RalfJung RalfJung left review comments

@oli-obk oli-obk oli-obk left review comments

@tgross35 tgross35 tgross35 approved these changes

Assignees

@RalfJung RalfJung

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.90.0
Development

Successfully merging this pull request may close these issues.
7 participants
@Randl @rustbot @tgross35 @oli-obk @lcnr @RalfJung @bors