Rehome ~150 tests/ui/issues/ tests to other subdirectories under tests/ui/
#143902
+617
−491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
Oneirical
force-pushed
the
uncountable-integer
branch
from
03a9549 to
2441737
Compare
Oneirical
changed the title
tests/ui/issues/ tests to other subdirectories under tests/ui/tests/ui/issues/ tests to other subdirectories under tests/ui/
This comment has been minimized.
This comment has been minimized.
rustbot
added
A-tidy
This comment has been minimized.
This comment has been minimized.
Oneirical
force-pushed
the
uncountable-integer
branch
from
93e148e to
4c6ea67
Compare
This comment has been minimized.
This comment has been minimized.
Oneirical
force-pushed
the
uncountable-integer
branch
from
4c6ea67 to
567002d
Compare
This comment has been minimized.
This comment has been minimized.
Oneirical
force-pushed
the
uncountable-integer
branch
from
567002d to
9b5900f
Compare
This comment has been minimized.
This comment has been minimized.
Oneirical
force-pushed
the
uncountable-integer
branch
from
9b5900f to
0e9469d
Compare
|
|
rustbot
added
S-waiting-on-review
|
There are changes to the cc @jieyouxu |
|
☔ The latest upstream changes (presumably #143958) made this pull request unmergeable. Please resolve the merge conflicts. |
|
(We discussed to split this into smaller more reviewable chunks.) @rustbot author |
rustbot
removed
the
S-waiting-on-review
|
Reminder, once the PR becomes ready for a review, use |
rustbot
added
the
S-waiting-on-author
|
Closed to divide into smaller fragments. |
rustbot
removed
the
S-waiting-on-author
tgross35
added a commit
to tgross35/rust
that referenced
this pull request
Jul 26, 2025
…=jieyouxu Rehome 35 `tests/ui/issues/` tests to other subdirectories under `tests/ui/` rust-lang#143902 divided into smaller, easier to review chunks. Part of rust-lang#133895 Methodology: 1. Refer to the previously written `tests/ui/SUMMARY.md` 2. Find an appropriate category for the test, using the original issue thread and the test contents. 3. Add the issue URL at the bottom (not at the top, as that would mess up stderr line numbers) 4. Rename the tests to make their purpose clearer The URL addition at the end, as well as moving around the auxiliary files and editing the `stderr` files with the new filename, were done using a Python script. Inspired by the methodology that `@Kivooeo` was using. r? `@jieyouxu`
rust-timer
added a commit
that referenced
this pull request
Jul 26, 2025
Rollup merge of #144089 - Oneirical:uncountable-integer-1, r=jieyouxu Rehome 35 `tests/ui/issues/` tests to other subdirectories under `tests/ui/` #143902 divided into smaller, easier to review chunks. Part of #133895 Methodology: 1. Refer to the previously written `tests/ui/SUMMARY.md` 2. Find an appropriate category for the test, using the original issue thread and the test contents. 3. Add the issue URL at the bottom (not at the top, as that would mess up stderr line numbers) 4. Rename the tests to make their purpose clearer The URL addition at the end, as well as moving around the auxiliary files and editing the `stderr` files with the new filename, were done using a Python script. Inspired by the methodology that `@Kivooeo` was using. r? `@jieyouxu`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Best reviewed commit-by-commit. I am pushing commits from my local branch as I am personally reviewing them for a first pass.
Part of #133895
Methodology:
tests/ui/SUMMARY.mdThe URL addition at the end, as well as moving around the auxiliary files and editing the
stderrfiles with the new filename, were done using a Python script.Inspired by the methodology that @Kivooeo was using.
r? @jieyouxu