-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Rehome ~150 tests/ui/issues/
tests to other subdirectories under tests/ui/
#143902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment has been minimized.
This comment has been minimized.
03a9549
to
2441737
Compare
tests/ui/issues/
tests to other subdirectories under tests/ui/
tests/ui/issues/
tests to other subdirectories under tests/ui/
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
93e148e
to
4c6ea67
Compare
This comment has been minimized.
This comment has been minimized.
4c6ea67
to
567002d
Compare
This comment has been minimized.
This comment has been minimized.
567002d
to
9b5900f
Compare
This comment has been minimized.
This comment has been minimized.
9b5900f
to
0e9469d
Compare
|
There are changes to the cc @jieyouxu |
☔ The latest upstream changes (presumably #143958) made this pull request unmergeable. Please resolve the merge conflicts. |
(We discussed to split this into smaller more reviewable chunks.) @rustbot author |
Reminder, once the PR becomes ready for a review, use |
Closed to divide into smaller fragments. |
…=jieyouxu Rehome 35 `tests/ui/issues/` tests to other subdirectories under `tests/ui/` rust-lang#143902 divided into smaller, easier to review chunks. Part of rust-lang#133895 Methodology: 1. Refer to the previously written `tests/ui/SUMMARY.md` 2. Find an appropriate category for the test, using the original issue thread and the test contents. 3. Add the issue URL at the bottom (not at the top, as that would mess up stderr line numbers) 4. Rename the tests to make their purpose clearer The URL addition at the end, as well as moving around the auxiliary files and editing the `stderr` files with the new filename, were done using a Python script. Inspired by the methodology that `@Kivooeo` was using. r? `@jieyouxu`
Rollup merge of #144089 - Oneirical:uncountable-integer-1, r=jieyouxu Rehome 35 `tests/ui/issues/` tests to other subdirectories under `tests/ui/` #143902 divided into smaller, easier to review chunks. Part of #133895 Methodology: 1. Refer to the previously written `tests/ui/SUMMARY.md` 2. Find an appropriate category for the test, using the original issue thread and the test contents. 3. Add the issue URL at the bottom (not at the top, as that would mess up stderr line numbers) 4. Rename the tests to make their purpose clearer The URL addition at the end, as well as moving around the auxiliary files and editing the `stderr` files with the new filename, were done using a Python script. Inspired by the methodology that `@Kivooeo` was using. r? `@jieyouxu`
Best reviewed commit-by-commit. I am pushing commits from my local branch as I am personally reviewing them for a first pass.
Part of #133895
Methodology:
tests/ui/SUMMARY.md
The URL addition at the end, as well as moving around the auxiliary files and editing the
stderr
files with the new filename, were done using a Python script.Inspired by the methodology that @Kivooeo was using.
r? @jieyouxu