Verify llvm-needs-components are not empty and match the --target value #144042

dpaoliello · 2025-07-16T23:22:01Z

I recently discovered a test with an empty llvm-needs-components entry (fixed in #143979) which meant that it didn't work correctly when building Rust with a limited set of LLVM targets.

This change makes a pair of improvements to prevent this issue from creeping in again:

When parsing directives with values, compiletest will now raise an error if there is an empty value.
Improved the target_specific_tests tidy checker to map targets to LLVM components, to verify that any existing llvm-needs-components contains the target being used.

I also fixed all the issues flagged by the improved tidy checker.

rustbot · 2025-07-16T23:22:05Z

r? @albertlarsan68

rustbot has assigned @albertlarsan68.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2025-07-16T23:22:09Z

Some changes occurred in tests/codegen/sanitizer

cc @rcvalle

There are changes to the tidy tool.

cc @jieyouxu

Some changes occurred in src/tools/compiletest

cc @jieyouxu

jieyouxu · 2025-07-17T06:01:27Z

r? jieyouxu

bors · 2025-07-20T01:47:47Z

☔ The latest upstream changes (presumably #144181) made this pull request unmergeable. Please resolve the merge conflicts.

bors · 2025-07-22T23:04:10Z

☔ The latest upstream changes (presumably #144249) made this pull request unmergeable. Please resolve the merge conflicts.

Verify llvm-needs-components are not empty and match the --target value I recently discovered a test with an empty `llvm-needs-components` entry (fixed in rust-lang#143979) which meant that it didn't work correctly when building Rust with a limited set of LLVM targets. This change makes a pair of improvements to prevent this issue from creeping in again: * When parsing directives with values, `compiletest` will now raise an error if there is an empty value. * Improved the `target_specific_tests` tidy checker to map targets to LLVM components, to verify that any existing `llvm-needs-components` contains the target being used. I also fixed all the issues flagged by the improved tidy checker.

Rollup of 9 pull requests Successful merges: - #140871 (Don't lint against named labels in `naked_asm!`) - #141663 (rustdoc: add ways of collapsing all impl blocks) - #143272 (Upgrade the `fortanix-sgx-abi` dependency) - #143585 (`loop_match`: suggest extracting to a `const` item) - #143698 (Fix unused_parens false positive) - #143859 (Guarantee 8 bytes of alignment in Thread::into_raw) - #144042 (Verify llvm-needs-components are not empty and match the --target value) - #144160 (tests: debuginfo: Work around or disable broken tests on powerpc) - #144431 (Disable has_reliable_f128_math on musl targets) r? `@ghost` `@rustbot` modify labels: rollup

tgross35 · 2025-07-26T07:14:36Z

@bors r-

Looks like the failure in #144485 (comment)

@bors2 try jobs=aarch64-msvc-1

Verify llvm-needs-components are not empty and match the --target value try-job: aarch64-msvc-1

rust-bors · 2025-07-26T07:14:40Z

⌛ Trying commit a5f73bf with merge c6017cc…

To cancel the try build, run the command @bors try cancel.

rust-bors · 2025-07-26T08:43:00Z

💔 Test failed (CI). Failed jobs:

bors build finished (web logs, extended logs)
try - aarch64-msvc-1 (web logs, extended logs)

jieyouxu · 2025-07-29T04:10:31Z

That directive is wrong, it's // cdb-check not //@ cdb-check, tho I think that uses LLVM FileCheck (?) so prefix wouldn't matter

dpaoliello · 2025-07-29T18:22:03Z

That directive is wrong, it's // cdb-check not //@ cdb-check, tho I think that uses LLVM FileCheck (?) so prefix wouldn't matter

I'm not sure if there's an easy way in directive.rs to know if the @ is required or not, so I've removed the comment part completely.

@rustbot ready

tgross35 · 2025-07-29T18:29:06Z

To be sure,
@bors2 try jobs=aarch64-msvc-1

rust-bors · 2025-07-29T18:29:10Z

⌛ Trying commit cffde73 with merge 130fb01…

To cancel the try build, run the command @bors try cancel.

Verify llvm-needs-components are not empty and match the --target value try-job: aarch64-msvc-1

rust-bors · 2025-07-29T20:42:29Z

☀️ Try build successful (CI)
Build commit: 130fb01 (130fb01e00d39b433f36c9626b9cbdde7ae5327a, parent: ac0cb05326706ef430a975aa85177e8642f2f457)

jieyouxu

Thanks. The changes in this PR are mostly fine, there's a few weird cases, but I think I'll look into them in a follow-up.

src/doc/rustc-dev-guide/src/tests/directives.md

tests/debuginfo/unsized.rs

src/tools/compiletest/src/runtest/debugger.rs

jieyouxu · 2025-07-30T06:16:17Z

@bors r+ rollup=iffy

bors · 2025-07-30T06:16:20Z

📌 Commit cffde73 has been approved by jieyouxu

It is now in the queue for this repository.

Verify llvm-needs-components are not empty and match the --target value I recently discovered a test with an empty `llvm-needs-components` entry (fixed in rust-lang#143979) which meant that it didn't work correctly when building Rust with a limited set of LLVM targets. This change makes a pair of improvements to prevent this issue from creeping in again: * When parsing directives with values, `compiletest` will now raise an error if there is an empty value. * Improved the `target_specific_tests` tidy checker to map targets to LLVM components, to verify that any existing `llvm-needs-components` contains the target being used. I also fixed all the issues flagged by the improved tidy checker.

rustbot assigned albertlarsan68 Jul 16, 2025

dpaoliello mentioned this pull request Jul 16, 2025

Test fixes for Arm64EC Windows #143979

Merged

rustbot assigned jieyouxu and unassigned albertlarsan68 Jul 17, 2025

dpaoliello force-pushed the verifyllvmcomp branch from 67d476a to 15dc6a8 Compare July 18, 2025 18:28

This comment has been minimized.

Sign in to view

dpaoliello force-pushed the verifyllvmcomp branch from 15dc6a8 to a852fa6 Compare July 18, 2025 20:40

This comment has been minimized.

Sign in to view

dpaoliello marked this pull request as draft July 18, 2025 21:30

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 18, 2025

dpaoliello force-pushed the verifyllvmcomp branch from a852fa6 to b3d78ec Compare July 18, 2025 21:47

This comment has been minimized.

Sign in to view

dpaoliello force-pushed the verifyllvmcomp branch from b3d78ec to 6a8c18b Compare July 18, 2025 22:38

dpaoliello force-pushed the verifyllvmcomp branch from 6a8c18b to 598e66f Compare July 21, 2025 17:37

dpaoliello marked this pull request as ready for review July 22, 2025 17:11

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 22, 2025

tgross35 mentioned this pull request Jul 26, 2025

Rollup of 9 pull requests #144485

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 26, 2025

rust-bors bot added a commit that referenced this pull request Jul 26, 2025

Auto merge of #144042 - dpaoliello:verifyllvmcomp, r=<try>

c6017cc

Verify llvm-needs-components are not empty and match the --target value try-job: aarch64-msvc-1

This comment has been minimized.

Sign in to view

jieyouxu mentioned this pull request Jul 29, 2025

[test] Correct llvm-component to tests that need x86 #144620

Closed

dpaoliello force-pushed the verifyllvmcomp branch from a5f73bf to 9560ffd Compare July 29, 2025 18:13

Verify llvm-needs-components are not empty and match the --target value

cffde73

dpaoliello force-pushed the verifyllvmcomp branch from 9560ffd to cffde73 Compare July 29, 2025 18:20

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 29, 2025

dpaoliello requested a review from jieyouxu July 29, 2025 18:22

rust-bors bot added a commit that referenced this pull request Jul 29, 2025

Auto merge of #144042 - dpaoliello:verifyllvmcomp, r=<try>

130fb01

Verify llvm-needs-components are not empty and match the --target value try-job: aarch64-msvc-1

jieyouxu approved these changes Jul 30, 2025

View reviewed changes

src/doc/rustc-dev-guide/src/tests/directives.md Show resolved Hide resolved

src/doc/rustc-dev-guide/src/tests/directives.md Show resolved Hide resolved

tests/debuginfo/unsized.rs Show resolved Hide resolved

src/tools/compiletest/src/runtest/debugger.rs Show resolved Hide resolved

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 30, 2025

Zalathar mentioned this pull request Jul 30, 2025

Rollup of 6 pull requests #144673

Open

Verify llvm-needs-components are not empty and match the --target value #144042

Are you sure you want to change the base?

Verify llvm-needs-components are not empty and match the --target value #144042

Conversation

dpaoliello commented Jul 16, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jul 16, 2025

Uh oh!

rustbot commented Jul 16, 2025

Uh oh!

jieyouxu commented Jul 17, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

bors commented Jul 20, 2025

Uh oh!

bors commented Jul 22, 2025

Uh oh!

tgross35 commented Jul 26, 2025

Uh oh!

rust-bors bot commented Jul 26, 2025

Uh oh!

This comment has been minimized.

rust-bors bot commented Jul 26, 2025

Uh oh!

jieyouxu commented Jul 29, 2025

Uh oh!

dpaoliello commented Jul 29, 2025

Uh oh!

tgross35 commented Jul 29, 2025

Uh oh!

rust-bors bot commented Jul 29, 2025

Uh oh!

rust-bors bot commented Jul 29, 2025

Uh oh!

jieyouxu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jieyouxu commented Jul 30, 2025

Uh oh!

bors commented Jul 30, 2025

Uh oh!

Uh oh!

dpaoliello commented Jul 16, 2025 •

edited by rustbot

Loading