Verify llvm-needs-components are not empty and match the --target value #144042
+277
−97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rustbot has assigned @albertlarsan68. Use |
rustbot
added
A-compiletest
|
r? jieyouxu |
dpaoliello
force-pushed
the
verifyllvmcomp
branch
from
67d476a to
15dc6a8
Compare
This comment has been minimized.
This comment has been minimized.
dpaoliello
force-pushed
the
verifyllvmcomp
branch
from
15dc6a8 to
a852fa6
Compare
This comment has been minimized.
This comment has been minimized.
rustbot
added
S-waiting-on-author
dpaoliello
force-pushed
the
verifyllvmcomp
branch
from
a852fa6 to
b3d78ec
Compare
This comment has been minimized.
This comment has been minimized.
dpaoliello
force-pushed
the
verifyllvmcomp
branch
from
b3d78ec to
6a8c18b
Compare
|
☔ The latest upstream changes (presumably #144181) made this pull request unmergeable. Please resolve the merge conflicts. |
dpaoliello
force-pushed
the
verifyllvmcomp
branch
from
6a8c18b to
598e66f
Compare
rustbot
added
S-waiting-on-review
|
☔ The latest upstream changes (presumably #144249) made this pull request unmergeable. Please resolve the merge conflicts. |
rust-bors bot
added a commit
that referenced
this pull request
Jul 26, 2025
Verify llvm-needs-components are not empty and match the --target value try-job: aarch64-msvc-1
This comment has been minimized.
This comment has been minimized.
|
💔 Test failed (CI). Failed jobs:
|
|
That directive is wrong, it's |
dpaoliello
force-pushed
the
verifyllvmcomp
branch
from
a5f73bf to
9560ffd
Compare
dpaoliello
force-pushed
the
verifyllvmcomp
branch
from
9560ffd to
cffde73
Compare
I'm not sure if there's an easy way in directive.rs to know if the @rustbot ready |
rustbot
added
S-waiting-on-review
|
To be sure, |
rust-bors bot
added a commit
that referenced
this pull request
Jul 29, 2025
Verify llvm-needs-components are not empty and match the --target value try-job: aarch64-msvc-1
jieyouxu
approved these changes
Jul 30, 2025
|
@bors r+ rollup=iffy |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jul 30, 2025
Rollup of 6 pull requests Successful merges: - #144042 (Verify llvm-needs-components are not empty and match the --target value) - #144268 (Add method `find_ancestor_not_from_macro` and `find_ancestor_not_from_extern_macro` to supersede `find_oldest_ancestor_in_same_ctxt`) - #144411 (Remove `hello_world` directory) - #144662 (compiletest: Move directive names back into a separate file) - #144666 (Make sure to account for the right item universal regions in borrowck) - #144668 ([test][run-make] add needs-llvm-components) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Jul 30, 2025
Rollup merge of #144042 - dpaoliello:verifyllvmcomp, r=jieyouxu Verify llvm-needs-components are not empty and match the --target value I recently discovered a test with an empty `llvm-needs-components` entry (fixed in #143979) which meant that it didn't work correctly when building Rust with a limited set of LLVM targets. This change makes a pair of improvements to prevent this issue from creeping in again: * When parsing directives with values, `compiletest` will now raise an error if there is an empty value. * Improved the `target_specific_tests` tidy checker to map targets to LLVM components, to verify that any existing `llvm-needs-components` contains the target being used. I also fixed all the issues flagged by the improved tidy checker.
github-actions bot
pushed a commit
to rust-lang/rustc-dev-guide
that referenced
this pull request
Jul 31, 2025
Rollup of 6 pull requests Successful merges: - rust-lang/rust#144042 (Verify llvm-needs-components are not empty and match the --target value) - rust-lang/rust#144268 (Add method `find_ancestor_not_from_macro` and `find_ancestor_not_from_extern_macro` to supersede `find_oldest_ancestor_in_same_ctxt`) - rust-lang/rust#144411 (Remove `hello_world` directory) - rust-lang/rust#144662 (compiletest: Move directive names back into a separate file) - rust-lang/rust#144666 (Make sure to account for the right item universal regions in borrowck) - rust-lang/rust#144668 ([test][run-make] add needs-llvm-components) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently discovered a test with an empty
llvm-needs-componentsentry (fixed in #143979) which meant that it didn't work correctly when building Rust with a limited set of LLVM targets.This change makes a pair of improvements to prevent this issue from creeping in again:
compiletestwill now raise an error if there is an empty value.target_specific_teststidy checker to map targets to LLVM components, to verify that any existingllvm-needs-componentscontains the target being used.I also fixed all the issues flagged by the improved tidy checker.