add AnonConstKind to non_trivial_const_arg diagnostics #144324
Draft
+111
−67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
rustbot
added
S-waiting-on-author
dvtkrlbs
commented
Jul 22, 2025
| item: Option<(Ident, ConstantItemKind)>, | ||
| f: impl FnOnce(&mut Self), | ||
| ) { | ||
| let f = |this: &mut Self| { | ||
| this.with_rib(ValueNS, RibKind::ConstantItem(may_use_generics, item), |this| { |
There was a problem hiding this comment.
Really not sure bout this one since it is nested ConstantItems
| @@ -3337,6 +3337,7 @@ impl<'ast, 'ra, 'tcx> LateResolutionVisitor<'_, 'ast, 'ra, 'tcx> { | |||
| .sess | |||
| .is_nightly_build() | |||
| .then_some(errors::ParamInNonTrivialAnonConstHelp), | |||
| place: AnonConstKind::InlineConst, | |||
There was a problem hiding this comment.
There is no context here so I am just defaulting to InlineConst. I need to fix this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#142387
r? @compiler-errors
one thing I am not sure about is if AnonConstKind is always available (if not not sure how to make it optional since IntoDiagArg is not implemented for Option). Especially in one of the late diagnostics there is no context to add AnonConstKind to an error (some diagnostics about lifetimes).