rustdoc layout template only emit crossorigin when needed
#144467
+9
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `crossorigin` attribute may cause issues when the href is not actuall across origins. Specifically, the tag causes the browser to send a preflight OPTIONS request to the href even if it is same-origin. Some tempermental servers may reject all CORS preflect requests even if they're actually same-origin, which causes a CORS error and prevents the fonts from loading, even later on. This commit fixes that problem by not emitting `crossorigin` if the url looks like a domain-relative url.
|
rustbot has assigned @GuillaumeGomez. Use |
rustbot
added
S-waiting-on-review
|
Seems ok to. Do you see any potential issue @notriddle? |
Co-authored-by: Guillaume Gomez <[email protected]>
| /// Determines if [`Self::static_route_path`] is relative to the same origin. | ||
| fn static_root_path_same_origin(&self) -> bool { | ||
| (self.static_root_path.starts_with('/') && !self.static_root_path.starts_with("//")) | ||
| || self.static_root_path.starts_with(".") |
There was a problem hiding this comment.
it's worth noting that this does not accurately check if a url is relative, as something like module/index.html is also relative.
these false negatives might not matter for fixing this bug, but it should probably be noted so noone tries to use this function for something it does matter for.
There was a problem hiding this comment.
Hmm good catch, I can try making it a little more robust
rustbot
added
S-waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
crossoriginattribute may cause issues when the href is not actually cross-origin. Specifically, the tag causes the browser to send a preflight OPTIONS request to the server even if it is same-origin. Some temperamental servers may reject all CORS preflight requests even if they're actually same-origin, which causes a CORS error and prevents the fonts from loading, even later on.This commit fixes that problem by not emitting
crossoriginif the url appears to be relative to the same origin.