Reject tail calls of #[track_caller]
functions
#144762
Open
+93
−31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make tail calls possible either both functions need to be
#[track_caller]
, or neither can. For simplicity I propose to just disallow using tail calling#[track_caller]
functions / tail calling from#[track_caller]
functions. I don't think#[track_caller]
is useful with tail calls anyway.However, we do need to have a quite late check, after monopolization (as otherwise you don't necessarily know if the callee has
#[track_caller]
).I'm not very happy with this implementation -- error'ing in the backend seems like a hack and will probably lead to disagreements between backends. Ideally we'd have a mir specific check (that would also probably make getting the span easier...).
Fixes #144755