Skip to content

inclusive Ranges: change end to last #144765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Qelxiros
Copy link
Contributor

@Qelxiros Qelxiros commented Aug 1, 2025

Tracking issue: #125687
ACP: rust-lang/libs-team#511

@rustbot
Copy link
Collaborator

rustbot commented Aug 1, 2025

r? @thomcc

rustbot has assigned @thomcc.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 1, 2025
@rust-log-analyzer
Copy link
Collaborator

The job aarch64-gnu-llvm-19-1 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
   Compiling rustc_index v0.0.0 (/checkout/compiler/rustc_index)
[RUSTC-TIMING] arrayref test:false 0.033
   Compiling rustc_graphviz v0.0.0 (/checkout/compiler/rustc_graphviz)
[RUSTC-TIMING] elsa test:false 0.465
error[E0560]: struct `std::range::RangeInclusive<usize>` has no field named `end`
   --> compiler/rustc_index/src/idx.rs:134:66
    |
134 |         core::range::RangeInclusive { start: self.start.index(), end: self.end.index() }
    |                                                                  ^^^ `std::range::RangeInclusive<_>` does not have this field
    |
    = note: available fields are: `last`

error[E0609]: no field `end` on type `std::range::RangeInclusive<I>`
   --> compiler/rustc_index/src/idx.rs:134:76
    |
134 |         core::range::RangeInclusive { start: self.start.index(), end: self.end.index() }
    |                                                                            ^^^ unknown field
    |
    = note: available fields are: `start`, `last`

[RUSTC-TIMING] rustc_graphviz test:false 0.456

@Qelxiros
Copy link
Contributor Author

Qelxiros commented Aug 1, 2025

The above error isn't fixed by changing end to last, since rustc is built with beta std. I'm not sure how to fix this, since I'm not super familiar with the bootstrapping process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants