Revert "Partially outline code inside the panic! macro".

[m-ou-se]

This reverts #115670

Without any tests/benchmarks that show some improvement, it's hard to know whether the change had any positive effect. (And if it did, whether that effect is still achieved today.)

[rustbot]

Some changes occurred to constck

cc @fee1-dead

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

[m-ou-se]

@bors try @rust-timer queue

[rust-bors]

☀️ Try build successful (CI)
Build commit: 77443d8 (77443d892dba8a7b2e4cd4eb0cc6b9e88f80fe30, parent: a1531335fe2807715fff569904d99602022643a7)

[rust-timer]

Finished benchmarking commit (77443d8): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.5%	[-0.5%, -0.5%]	3
Improvements ✅ (secondary)	-0.1%	[-0.1%, -0.1%]	3
All ❌✅ (primary)	-0.5%	[-0.5%, -0.5%]	3

Max RSS (memory usage)

Results (primary 3.9%, secondary -3.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	3.9%	[3.5%, 4.4%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.8%	[-3.8%, -3.8%]	1
All ❌✅ (primary)	3.9%	[3.5%, 4.4%]	2

Cycles

Results (primary -2.5%, secondary -3.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.5%	[-2.5%, -2.4%]	2
Improvements ✅ (secondary)	-3.3%	[-3.3%, -3.3%]	1
All ❌✅ (primary)	-2.5%	[-2.5%, -2.4%]	2

Binary size

Results (primary -0.0%, secondary -0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.1%, 0.1%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.1%	[-0.1%, -0.0%]	18
Improvements ✅ (secondary)	-0.0%	[-0.1%, -0.0%]	3
All ❌✅ (primary)	-0.0%	[-0.1%, 0.1%]	19

Bootstrap: 465.439s -> 465.691s (0.05%)
Artifact size: 377.34 MiB -> 377.37 MiB (0.01%)

[oli-obk]

@bors r+

Yay perf improvements. Mostly due to fewer query calls and thus less dep graph edges

[bors]

📌 Commit 08acba3 has been approved by oli-obk

It is now in the queue for this repository.

[Zoxc]

Keep in mind that it likely regresses code quality.