ci: clean windows disk space in background #145311
Draft
+139
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-CI
|
@bors try jobs=msvc,mingw |
This comment has been minimized.
This comment has been minimized.
rust-bors bot
added a commit
that referenced
this pull request
Aug 12, 2025
…=<try> ci: clean windows disk space in background try-job: *msvc* try-job: *mingw*
|
💔 Test for 8cf61b6 failed: CI. Failed jobs:
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
marcoieni
force-pushed
the
clean-disk-in-background-windows
branch
from
d3be181 to
2290350
Compare
This comment has been minimized.
This comment has been minimized.
marcoieni
force-pushed
the
clean-disk-in-background-windows
branch
from
2290350 to
2434d72
Compare
This comment has been minimized.
This comment has been minimized.
marcoieni
force-pushed
the
clean-disk-in-background-windows
branch
from
2434d72 to
ee2962a
Compare
|
@bors try jobs=msvc,mingw |
This comment has been minimized.
This comment has been minimized.
rust-bors bot
added a commit
that referenced
this pull request
Aug 13, 2025
…=<try> ci: clean windows disk space in background try-job: *msvc* try-job: *mingw*
|
Now cleaning the disk space takes 0 seconds. Nice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speed up cleaning up disk space by launching the process in the background.
We wait for it to finish before running the build.
The con of this PR is that it adds extra complexity. However, cleaning up disk space on windows can take a lot of time (in the latest auto build I saw one job taking 8 minutes for example).
Context
The disk space cleanup was introduced in #144305
Test
I tested that the waiting mechanism works in https://github.com/marcoieni/actions-test/actions/runs/16935555049/job/47991148801:
Overall speed
I compared the duration of the jobs of the try build with the latest auto build and I noticed a speed up in most of the jobs. Some jobs are slower but that's probably because of unrelated CI reasons.