Skip to content

Remove usage of remarks::SerializerMode when building against upstream LLVM #146914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Remove usage of remarks::SerializerMode when building against upstream LLVM #146914

wants to merge 1 commit into from
+5 −0

Conversation

alanzhao1
Copy link

This has been removed by
llvm/llvm-project#156715.

@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 22, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 22, 2025

r? @cuviper

rustbot has assigned @cuviper.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@cuviper
Copy link
Member

cuviper commented Sep 22, 2025

I think #146905 has beat you to it. :)

@alanzhao1
Copy link
Author

I think #146905 has beat you to it. :)

D'oh!. I'll close this then.

@alanzhao1 alanzhao1 closed this Sep 22, 2025
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 22, 2025
@alanzhao1 alanzhao1 deleted the bugfix/remove-serlialization-mode branch September 22, 2025 22:03
@rust-log-analyzer
Copy link
Collaborator

The job pr-check-2 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
warning: [email protected]: llvm-wrapper/RustWrapper.cpp: In function 'void LLVMRustContextConfigureDiagnosticHandler(LLVMContextRef, LLVMDiagnosticHandlerTy, void*, bool, const char* const*, size_t, const char*, bool)':
warning: [email protected]: llvm-wrapper/RustWrapper.cpp:1783:60: error: no matching function for call to 'createRemarkSerializer(llvm::remarks::Format, llvm::raw_fd_ostream&)'
warning: [email protected]:  1783 |     auto RemarkSerializer = remarks::createRemarkSerializer(
warning: [email protected]:       |                             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
warning: [email protected]:  1784 |         llvm::remarks::Format::YAML, RemarkFile->os());
warning: [email protected]:       |         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~      
warning: [email protected]: In file included from llvm-wrapper/RustWrapper.cpp:29:
warning: [email protected]: /checkout/obj/build/x86_64-unknown-linux-gnu/ci-llvm/include/llvm/Remarks/RemarkSerializer.h:82:1: note: candidate: 'llvm::Expected<std::unique_ptr<llvm::remarks::RemarkSerializer> > llvm::remarks::createRemarkSerializer(llvm::remarks::Format, llvm::remarks::SerializerMode, llvm::raw_ostream&)'
warning: [email protected]:    82 | createRemarkSerializer(Format RemarksFormat, SerializerMode Mode,
warning: [email protected]:       | ^~~~~~~~~~~~~~~~~~~~~~
warning: [email protected]: /checkout/obj/build/x86_64-unknown-linux-gnu/ci-llvm/include/llvm/Remarks/RemarkSerializer.h:82:1: note:   candidate expects 3 arguments, 2 provided
warning: [email protected]: /checkout/obj/build/x86_64-unknown-linux-gnu/ci-llvm/include/llvm/Remarks/RemarkSerializer.h:87:1: note: candidate: 'llvm::Expected<std::unique_ptr<llvm::remarks::RemarkSerializer> > llvm::remarks::createRemarkSerializer(llvm::remarks::Format, llvm::remarks::SerializerMode, llvm::raw_ostream&, llvm::remarks::StringTable)'
warning: [email protected]:    87 | createRemarkSerializer(Format RemarksFormat, SerializerMode Mode,
warning: [email protected]:       | ^~~~~~~~~~~~~~~~~~~~~~
warning: [email protected]: /checkout/obj/build/x86_64-unknown-linux-gnu/ci-llvm/include/llvm/Remarks/RemarkSerializer.h:87:1: note:   candidate expects 4 arguments, 2 provided
error: failed to run custom build command for `rustc_llvm v0.0.0 (/checkout/compiler/rustc_llvm)`
note: To improve backtraces for build dependencies, set the CARGO_PROFILE_RELEASE_BUILD_OVERRIDE_DEBUG=true environment variable to enable debug information generation.

Caused by:
  process didn't exit successfully: `/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-rustc/release/build/rustc_llvm-9e5b8b4d9e15a4dc/build-script-build` (exit status: 1)
  --- stdout
  cargo:rustc-check-cfg=cfg(llvm_component,values("ipo"))
  cargo:rustc-check-cfg=cfg(llvm_component,values("bitreader"))
  cargo:rustc-check-cfg=cfg(llvm_component,values("bitwriter"))
  cargo:rustc-check-cfg=cfg(llvm_component,values("linker"))
  cargo:rustc-check-cfg=cfg(llvm_component,values("asmparser"))
  cargo:rustc-check-cfg=cfg(llvm_component,values("lto"))
  cargo:rustc-check-cfg=cfg(llvm_component,values("coverage"))
  cargo:rustc-check-cfg=cfg(llvm_component,values("instrumentation"))
  cargo:rustc-check-cfg=cfg(llvm_component,values("x86"))
  cargo:rustc-check-cfg=cfg(llvm_component,values("arm"))
  cargo:rustc-check-cfg=cfg(llvm_component,values("aarch64"))
  cargo:rustc-check-cfg=cfg(llvm_component,values("amdgpu"))
  cargo:rustc-check-cfg=cfg(llvm_component,values("avr"))
  cargo:rustc-check-cfg=cfg(llvm_component,values("loongarch"))
  cargo:rustc-check-cfg=cfg(llvm_component,values("m68k"))
  cargo:rustc-check-cfg=cfg(llvm_component,values("csky"))
  cargo:rustc-check-cfg=cfg(llvm_component,values("mips"))
  cargo:rustc-check-cfg=cfg(llvm_component,values("powerpc"))
  cargo:rustc-check-cfg=cfg(llvm_component,values("systemz"))
  cargo:rustc-check-cfg=cfg(llvm_component,values("webassembly"))
  cargo:rustc-check-cfg=cfg(llvm_component,values("msp430"))
  cargo:rustc-check-cfg=cfg(llvm_component,values("sparc"))
  cargo:rustc-check-cfg=cfg(llvm_component,values("nvptx"))
  cargo:rustc-check-cfg=cfg(llvm_component,values("hexagon"))
  cargo:rustc-check-cfg=cfg(llvm_component,values("riscv"))
  cargo:rustc-check-cfg=cfg(llvm_component,values("xtensa"))
  cargo:rustc-check-cfg=cfg(llvm_component,values("bpf"))
  cargo:rerun-if-env-changed=RUST_CHECK
  cargo:rerun-if-env-changed=REAL_LIBRARY_PATH_VAR
  cargo:rerun-if-env-changed=REAL_LIBRARY_PATH
  cargo:rerun-if-env-changed=LLVM_CONFIG
  cargo:rerun-if-changed=/checkout/obj/build/x86_64-unknown-linux-gnu/ci-llvm/bin/llvm-config
  cargo:rustc-cfg=llvm_component="aarch64"
  cargo:rustc-cfg=llvm_component="amdgpu"
  cargo:rustc-cfg=llvm_component="arm"
  cargo:rustc-cfg=llvm_component="asmparser"
  cargo:rustc-cfg=llvm_component="avr"
  cargo:rustc-cfg=llvm_component="bitreader"
  cargo:rustc-cfg=llvm_component="bitwriter"
  cargo:rustc-cfg=llvm_component="bpf"
  cargo:rustc-cfg=llvm_component="coverage"
  cargo:rustc-cfg=llvm_component="csky"
  cargo:rustc-cfg=llvm_component="hexagon"
  cargo:rustc-cfg=llvm_component="instrumentation"
  cargo:rustc-cfg=llvm_component="ipo"
  cargo:rustc-cfg=llvm_component="linker"
  cargo:rustc-cfg=llvm_component="loongarch"
  cargo:rustc-cfg=llvm_component="lto"
  cargo:rustc-cfg=llvm_component="m68k"
  cargo:rustc-cfg=llvm_component="mips"
  cargo:rustc-cfg=llvm_component="msp430"
  cargo:rustc-cfg=llvm_component="nvptx"
  cargo:rustc-cfg=llvm_component="powerpc"
  cargo:rustc-cfg=llvm_component="riscv"
  cargo:rustc-cfg=llvm_component="sparc"
  cargo:rustc-cfg=llvm_component="systemz"
  cargo:rustc-cfg=llvm_component="webassembly"
  cargo:rustc-cfg=llvm_component="x86"
  cargo:rustc-cfg=llvm_component="xtensa"
  cargo:rerun-if-env-changed=LLVM_ENZYME
  cargo:rerun-if-env-changed=LLVM_RUSTLLVM
  cargo:rerun-if-env-changed=LLVM_ASSERTIONS
  cargo:rerun-if-changed=llvm-wrapper/PassWrapper.cpp
  cargo:rerun-if-changed=llvm-wrapper/LLVMWrapper.h
  cargo:rerun-if-changed=llvm-wrapper/README
  cargo:rerun-if-changed=llvm-wrapper/SuppressLLVMWarnings.h
  cargo:rerun-if-changed=llvm-wrapper/Linker.cpp
  cargo:rerun-if-changed=llvm-wrapper/RustWrapper.cpp
  cargo:rerun-if-changed=llvm-wrapper/SymbolWrapper.cpp
  cargo:rerun-if-changed=llvm-wrapper/CoverageMappingWrapper.cpp
  cargo:rerun-if-changed=llvm-wrapper/.editorconfig
  OUT_DIR = Some(/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-rustc/x86_64-unknown-linux-gnu/release/build/rustc_llvm-06f447f4c3b36d13/out)
  OPT_LEVEL = Some(3)
  TARGET = Some(x86_64-unknown-linux-gnu)
  HOST = Some(x86_64-unknown-linux-gnu)
  cargo:rerun-if-env-changed=CXX_x86_64-unknown-linux-gnu
  CXX_x86_64-unknown-linux-gnu = None
---
  RUSTC_WRAPPER = Some(sccache)
  cargo:rerun-if-env-changed=CRATE_CC_NO_DEFAULTS
  CRATE_CC_NO_DEFAULTS = None
  DEBUG = Some(false)
  CARGO_CFG_TARGET_FEATURE = Some(fxsr,sse,sse2,x87)
  cargo:rerun-if-env-changed=CXXFLAGS
  CXXFLAGS = None
  cargo:rerun-if-env-changed=HOST_CXXFLAGS
  HOST_CXXFLAGS = None
  cargo:rerun-if-env-changed=CXXFLAGS_x86_64_unknown_linux_gnu
  CXXFLAGS_x86_64_unknown_linux_gnu = None
  cargo:rerun-if-env-changed=CXXFLAGS_x86_64-unknown-linux-gnu
  CXXFLAGS_x86_64-unknown-linux-gnu = None
  CARGO_ENCODED_RUSTFLAGS = Some(--cfg=bootstrap--cfg=windows_raw_dylib-Csymbol-mangling-version=v0-Zunstable-options--check-cfg=cfg(bootstrap)-Zmacro-backtrace-Csplit-debuginfo=off-Zon-broken-pipe=kill)
  cargo:warning=llvm-wrapper/RustWrapper.cpp: In function 'void LLVMRustContextConfigureDiagnosticHandler(LLVMContextRef, LLVMDiagnosticHandlerTy, void*, bool, const char* const*, size_t, const char*, bool)':
  cargo:warning=llvm-wrapper/RustWrapper.cpp:1783:60: error: no matching function for call to 'createRemarkSerializer(llvm::remarks::Format, llvm::raw_fd_ostream&)'
  cargo:warning= 1783 |     auto RemarkSerializer = remarks::createRemarkSerializer(
  cargo:warning=      |                             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
  cargo:warning= 1784 |         llvm::remarks::Format::YAML, RemarkFile->os());
  cargo:warning=      |         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~      
  cargo:warning=In file included from llvm-wrapper/RustWrapper.cpp:29:
  cargo:warning=/checkout/obj/build/x86_64-unknown-linux-gnu/ci-llvm/include/llvm/Remarks/RemarkSerializer.h:82:1: note: candidate: 'llvm::Expected<std::unique_ptr<llvm::remarks::RemarkSerializer> > llvm::remarks::createRemarkSerializer(llvm::remarks::Format, llvm::remarks::SerializerMode, llvm::raw_ostream&)'
  cargo:warning=   82 | createRemarkSerializer(Format RemarksFormat, SerializerMode Mode,
  cargo:warning=      | ^~~~~~~~~~~~~~~~~~~~~~
  cargo:warning=/checkout/obj/build/x86_64-unknown-linux-gnu/ci-llvm/include/llvm/Remarks/RemarkSerializer.h:82:1: note:   candidate expects 3 arguments, 2 provided
  cargo:warning=/checkout/obj/build/x86_64-unknown-linux-gnu/ci-llvm/include/llvm/Remarks/RemarkSerializer.h:87:1: note: candidate: 'llvm::Expected<std::unique_ptr<llvm::remarks::RemarkSerializer> > llvm::remarks::createRemarkSerializer(llvm::remarks::Format, llvm::remarks::SerializerMode, llvm::raw_ostream&, llvm::remarks::StringTable)'
  cargo:warning=   87 | createRemarkSerializer(Format RemarksFormat, SerializerMode Mode,
  cargo:warning=      | ^~~~~~~~~~~~~~~~~~~~~~
  cargo:warning=/checkout/obj/build/x86_64-unknown-linux-gnu/ci-llvm/include/llvm/Remarks/RemarkSerializer.h:87:1: note:   candidate expects 4 arguments, 2 provided

  --- stderr


  error occurred in cc-rs: command did not execute successfully (status code exit status: 1): LC_ALL="C" "sccache" "c++" "-O3" "-ffunction-sections" "-fdata-sections" "-fPIC" "-m64" "-Werror" "-I/checkout/obj/build/x86_64-unknown-linux-gnu/ci-llvm/include" "-std=c++17" "-fno-exceptions" "-funwind-tables" "-fno-rtti" "-D_GNU_SOURCE" "-D_DEBUG" "-D_GLIBCXX_ASSERTIONS" "-DEXPERIMENTAL_KEY_INSTRUCTIONS" "-D__STDC_CONSTANT_MACROS" "-D__STDC_FORMAT_MACROS" "-D__STDC_LIMIT_MACROS" "-DLLVM_COMPONENT_AARCH64" "-DLLVM_COMPONENT_AMDGPU" "-DLLVM_COMPONENT_ARM" "-DLLVM_COMPONENT_ASMPARSER" "-DLLVM_COMPONENT_AVR" "-DLLVM_COMPONENT_BITREADER" "-DLLVM_COMPONENT_BITWRITER" "-DLLVM_COMPONENT_BPF" "-DLLVM_COMPONENT_COVERAGE" "-DLLVM_COMPONENT_CSKY" "-DLLVM_COMPONENT_HEXAGON" "-DLLVM_COMPONENT_INSTRUMENTATION" "-DLLVM_COMPONENT_IPO" "-DLLVM_COMPONENT_LINKER" "-DLLVM_COMPONENT_LOONGARCH" "-DLLVM_COMPONENT_LTO" "-DLLVM_COMPONENT_M68K" "-DLLVM_COMPONENT_MIPS" "-DLLVM_COMPONENT_MSP430" "-DLLVM_COMPONENT_NVPTX" "-DLLVM_COMPONENT_POWERPC" "-DLLVM_COMPONENT_RISCV" "-DLLVM_COMPONENT_SPARC" "-DLLVM_COMPONENT_SYSTEMZ" "-DLLVM_COMPONENT_WEBASSEMBLY" "-DLLVM_COMPONENT_X86" "-DLLVM_COMPONENT_XTENSA" "-DLLVM_RUSTLLVM" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-rustc/x86_64-unknown-linux-gnu/release/build/rustc_llvm-06f447f4c3b36d13/out/ef10e86dc40538c1-RustWrapper.o" "-c" "llvm-wrapper/RustWrapper.cpp"


warning: build failed, waiting for other jobs to finish...
[RUSTC-TIMING] thiserror test:false 0.036
[RUSTC-TIMING] rustc_query_impl test:false 7.827

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cuviper cuviper

Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alanzhao1 @rustbot @cuviper @rust-log-analyzer