perf experiment: try to get rid of box_new

[RalfJung]

No description provided.

[RalfJung]

@bors try
@rust-timer queue

[RalfJung]

@bors try

[rust-bors]

☀️ Try build successful (CI)
Build commit: 23a3fb3 (23a3fb398aa8883e29eb8f4dc5e50f725e7f5ab5, parent: fd847d4d5d5d1e96bde2d97635faec8655da6b18)

[RalfJung]

@bors try
@rust-timer queue

[RalfJung]

@bors try

[rust-bors]

☀️ Try build successful (CI)
Build commit: 7d2ffdd (7d2ffdde04d9b67a612102fd250175973885834a, parent: 23fced0fcc5e0ec260d25f04a8b78b269e5e90f0)

[rust-timer]

Finished benchmarking commit (7d2ffdd): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.2%	[0.1%, 0.4%]	3
Regressions ❌ (secondary)	0.9%	[0.2%, 1.5%]	23
Improvements ✅ (primary)	-0.6%	[-0.6%, -0.6%]	1
Improvements ✅ (secondary)	-0.1%	[-0.1%, -0.1%]	1
All ❌✅ (primary)	0.0%	[-0.6%, 0.4%]	4

Max RSS (memory usage)

Results (primary -1.6%, secondary -4.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.1%	[0.9%, 2.9%]	3
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-3.2%	[-7.0%, -0.7%]	7
Improvements ✅ (secondary)	-4.5%	[-5.7%, -2.4%]	8
All ❌✅ (primary)	-1.6%	[-7.0%, 2.9%]	10

Cycles

Results (secondary -6.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-6.9%	[-6.9%, -6.9%]	1
All ❌✅ (primary)	-	-	0

Binary size

Results (primary 0.1%, secondary 1.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.2%	[0.0%, 0.5%]	33
Regressions ❌ (secondary)	1.8%	[0.0%, 2.7%]	17
Improvements ✅ (primary)	-0.1%	[-0.3%, -0.0%]	15
Improvements ✅ (secondary)	-0.0%	[-0.0%, -0.0%]	1
All ❌✅ (primary)	0.1%	[-0.3%, 0.5%]	48

Bootstrap: 475.144s -> 474.953s (-0.04%)
Artifact size: 390.52 MiB -> 390.57 MiB (0.01%)

[RalfJung]

@rust-timer queue
@bors try

[rust-log-analyzer]

The job x86_64-gnu-gcc failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

test [codegen-units] tests/codegen-units/item-collection/non-generic-closures.rs ... ok
test [codegen-units] tests/codegen-units/item-collection/statics-and-consts.rs ... ok
test [codegen-units] tests/codegen-units/item-collection/static-init.rs ... ok
test [codegen-units] tests/codegen-units/item-collection/overloaded-operators.rs ... ok
FATAL: !(missing.is_empty() && unexpected.is_empty() && wrong_cgus.is_empty())
test [codegen-units] tests/codegen-units/item-collection/opaque-return-impls.rs ... FAILED
test [codegen-units] tests/codegen-units/item-collection/trait-implementations.rs ... ok
test [codegen-units] tests/codegen-units/item-collection/trait-method-default-impl.rs ... ok
test [codegen-units] tests/codegen-units/item-collection/trait-method-as-argument.rs ... ok
test [codegen-units] tests/codegen-units/item-collection/transitive-drop-glue.rs ... ok
---


These items were contained but should not have been:

MONO_ITEM fn std::boxed::box_new_uninit @@ opaque_return_impls.a116a005f37f8ef5-cgu.0[Internal]



thread '[codegen-units] tests/codegen-units/item-collection/opaque-return-impls.rs' panicked at src/tools/compiletest/src/runtest/codegen_units.rs:111:13:
fatal error

For more information how to resolve CI failures of this job, visit this link.

[rust-bors]

☀️ Try build successful (CI)
Build commit: c229d30 (c229d30a5dc7dc44dfa0816ccbb69d0e77db8b4d, parent: 4b53279854fcc60b063398181f5dc13ddc319cb8)

[rust-timer]

Finished benchmarking commit (c229d30): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.2%	[0.1%, 0.4%]	3
Regressions ❌ (secondary)	0.9%	[0.2%, 1.5%]	18
Improvements ✅ (primary)	-0.5%	[-0.5%, -0.5%]	1
Improvements ✅ (secondary)	-1.3%	[-2.0%, -0.7%]	3
All ❌✅ (primary)	0.0%	[-0.5%, 0.4%]	4

Max RSS (memory usage)

Results (primary 2.7%, secondary -3.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	3.9%	[2.1%, 5.7%]	4
Regressions ❌ (secondary)	2.1%	[2.1%, 2.1%]	1
Improvements ✅ (primary)	-2.1%	[-2.1%, -2.1%]	1
Improvements ✅ (secondary)	-4.5%	[-9.0%, -2.3%]	9
All ❌✅ (primary)	2.7%	[-2.1%, 5.7%]	5

Cycles

Results (secondary 3.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	6.5%	[3.6%, 9.4%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.3%	[-2.3%, -2.3%]	1
All ❌✅ (primary)	-	-	0

Binary size

Results (primary 0.0%, secondary 1.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.0%, 0.3%]	21
Regressions ❌ (secondary)	1.0%	[0.0%, 2.0%]	17
Improvements ✅ (primary)	-0.1%	[-0.3%, -0.0%]	12
Improvements ✅ (secondary)	-0.0%	[-0.0%, -0.0%]	1
All ❌✅ (primary)	0.0%	[-0.3%, 0.3%]	33

Bootstrap: 474.938s -> 477.512s (0.54%)
Artifact size: 390.59 MiB -> 390.65 MiB (0.01%)