Skip to content

tests/debuginfo/closures.rs: Activate misspelled cdb-check #148097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

tests/debuginfo/closures.rs: Activate misspelled cdb-check #148097

wants to merge 1 commit into from

Conversation

@Enselic
Copy link
Member

@Enselic Enselic commented Oct 25, 2025 •
edited
Loading

Split out from #147799 because these seemingly simple corrections can turn out to be non-trivial. See #147728 for example.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 25, 2025
@rustbot

This comment was marked as outdated.

Sign in to view
@Enselic
Copy link
Member Author

Enselic commented Oct 25, 2025 •
edited
Loading

Re-rolling reviewer since Mark-Simulacrum is already assigned to #147728 and I want to spread the load.

r? compiler

@rustbot rustbot assigned jackh726 and unassigned Mark-Simulacrum Oct 25, 2025
@Zalathar
Copy link
Member

Zalathar commented Oct 25, 2025

@bors try jobs=x86_64-msvc-1,i686-msvc-1

rust-bors bot added a commit that referenced this pull request Oct 25, 2025
@rust-bors
Auto merge of #148097 - Enselic:misspelled-cdb-check, r=<try>
a11f19e 
tests/debuginfo/closures.rs: Activate misspelled `cdb-check`

try-job: x86_64-msvc-1
try-job: i686-msvc-1
@rust-bors

This comment has been minimized.

Sign in to view
@Enselic Enselic mentioned this pull request Oct 25, 2025
Open
1 task
@rust-bors
Copy link

rust-bors bot commented Oct 25, 2025

☀️ Try build successful (CI)
Build commit: a11f19e (a11f19eb2d175d49117f9da104486af3c0ccf01a, parent: 04ff05c9c0cfbca33115c5f1b8bb20a66a54b799)

@Zalathar Zalathar mentioned this pull request Oct 26, 2025
Merged
@Zalathar
Copy link
Member

Zalathar commented Oct 26, 2025

This passed try jobs, so let's just merge it without further ceremony.

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Oct 26, 2025

📌 Commit 76b9c23 has been approved by Zalathar

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 26, 2025
Zalathar added a commit to Zalathar/rust that referenced this pull request Oct 26, 2025
@Zalathar
Rollup merge of rust-lang#148097 - Enselic:misspelled-cdb-check, r=Za…
c7ebf73 
…lathar

tests/debuginfo/closures.rs: Activate misspelled `cdb-check`

Split out from rust-lang#147799 because these seemingly simple corrections can turn out to be non-trivial. See rust-lang#147728 for example.
@Zalathar Zalathar mentioned this pull request Oct 26, 2025
Closed
bors added a commit that referenced this pull request Oct 26, 2025
@bors
Auto merge of #148123 - Zalathar:rollup-zlxn01b, r=Zalathar
5f3f2be 
Rollup of 4 pull requests

Successful merges:

 - #145665 (Don't require `T: RefUnwindSafe` for `vec::IntoIter<T>: UnwindSafe`)
 - #147728 (tests: activate misspelled `gdb-check` in `function-arg-initialization.rs`)
 - #148097 (tests/debuginfo/closures.rs: Activate misspelled `cdb-check`)
 - #148118 (Improve the ICE message for invalid nullary intrinsic calls)

r? `@ghost`
`@rustbot` modify labels: rollup
Zalathar added a commit to Zalathar/rust that referenced this pull request Oct 26, 2025
@Zalathar
Rollup merge of rust-lang#148097 - Enselic:misspelled-cdb-check, r=Za…
5999e9c 
…lathar

tests/debuginfo/closures.rs: Activate misspelled `cdb-check`

Split out from rust-lang#147799 because these seemingly simple corrections can turn out to be non-trivial. See rust-lang#147728 for example.
@Zalathar Zalathar mentioned this pull request Oct 26, 2025
Closed
bors added a commit that referenced this pull request Oct 26, 2025
@bors
Auto merge of #148127 - Zalathar:rollup-e0zlieo, r=Zalathar
f7dc759 
Rollup of 2 pull requests

Successful merges:

 - #148097 (tests/debuginfo/closures.rs: Activate misspelled `cdb-check`)
 - #148118 (Improve the ICE message for invalid nullary intrinsic calls)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Oct 26, 2025
@bors
Auto merge of #148097 - Enselic:misspelled-cdb-check, r=Zalathar
3bcdb11 
tests/debuginfo/closures.rs: Activate misspelled `cdb-check`

Split out from #147799 because these seemingly simple corrections can turn out to be non-trivial. See #147728 for example.
@bors
Copy link
Collaborator

bors commented Oct 26, 2025

⌛ Testing commit 76b9c23 with merge 3bcdb11...

@Zalathar
Copy link
Member

Zalathar commented Oct 26, 2025

Failed in rollup in aarch64-msvc-1: #148127 (comment)

@bors r- retry

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 26, 2025
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 26, 2025
@Enselic
Copy link
Member Author

Enselic commented Oct 28, 2025

Bors seems to be in an invalid state. Maybe this will fix it:

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 28, 2025
@Enselic
Copy link
Member Author

Enselic commented Oct 30, 2025 •
edited
Loading

Strange. In the failure we can read:

error: check directive(s) from `C:\a\rust\rust\tests\debuginfo\closures.rs` not found in debugger output. errors:
    (closures.rs:20) `simple_closure   [Type: closures::main::closure_env$5]`

but in the output we can find that exact line byte-by-byte:

0:000> dx simple_closure
simple_closure   [Type: closures::main::closure_env$5]

I can also reproduce this on x86_64-pc-windows-msvc. Unfortunately I don't have the time and energy to go to the bottom of this, so I'll go ahead and close this PR.

I will add a FIXME as part of #147799.

@Enselic Enselic closed this Oct 30, 2025
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Oct 30, 2025
Enselic added a commit to Enselic/rust that referenced this pull request Oct 31, 2025
@Enselic
tests: Use //@ prefixes also for debuginfo test directives
02dff18 
So that when we later add support for revisions we can use the same
syntax for revisions as elsewhere.

This also prevents people from making typos for commands since
`src/tools/compiletest/src/directives/directive_names.rs` will catch such
typos now.

Note that we add three FIXMEs for non-trivial changes that need to be done later:
```
// FIXME(rust-lang#148097): Change `// cdb-checksimple_closure` to `//@ cdb-check:simple_closure`
// FIXME(rust-lang#147728): Change `// gdbt-check` to `//@ gdb-check`
// FIXME(rust-lang#147728): Change `// gdbt-check` to `//@ gdb-check`
```
Enselic added a commit to Enselic/rust that referenced this pull request Oct 31, 2025
@Enselic
tests: Use //@ prefixes also for debuginfo test directives
d1e703a 
So that when we later add support for revisions we can use the same
syntax for revisions as elsewhere.

This also prevents people from making typos for commands since
`src/tools/compiletest/src/directives/directive_names.rs` will catch such
typos now.

Note that we add three FIXMEs for non-trivial changes that need to be done later:
```
// FIXME(rust-lang#148097): Change `// cdb-checksimple_closure` to `//@ cdb-check:simple_closure`
// FIXME(rust-lang#147728): Change `// gdbt-check` to `//@ gdb-check` and remove `linelength` ignore above
// FIXME(rust-lang#147728): Change `// gdbt-check` to `//@ gdb-check`
```
Enselic added a commit to Enselic/rust that referenced this pull request Oct 31, 2025
@Enselic
tests: Use //@ prefixes also for debuginfo test directives
74887a7 
So that when we later add support for revisions we can use the same
syntax for revisions as elsewhere.

This also prevents people from making typos for commands since
`src/tools/compiletest/src/directives/directive_names.rs` will catch such
typos now.

Note that we add three FIXMEs for non-trivial changes that need to be done later:
```
// FIXME(rust-lang#148097): Change `// cdb-checksimple_closure` to `//@ cdb-check:simple_closure`
// FIXME(rust-lang#147728): Change `// gdbt-check` to `//@ gdb-check` and remove `linelength` ignore above
// FIXME(rust-lang#147728): Change `// gdbt-check` to `//@ gdb-check`
```
Enselic added a commit to Enselic/rust that referenced this pull request Oct 31, 2025
@Enselic
compiletest: Use //@ prefixes also for debuginfo test directives
6820013 
So that when we later add support for revisions we can use the same
syntax for revisions as elsewhere.

This also prevents people from making typos for commands since
`src/tools/compiletest/src/directives/directive_names.rs` will catch such
typos now.

Note that we add three FIXMEs for non-trivial changes that need to be done later:
```
// FIXME(rust-lang#148097): Change `// cdb-checksimple_closure` to `//@ cdb-check:simple_closure`
// FIXME(rust-lang#147728): Change `// gdbt-check` to `//@ gdb-check` and remove `linelength` ignore above
// FIXME(rust-lang#147728): Change `// gdbt-check` to `//@ gdb-check`
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jackh726 jackh726

Labels

T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Enselic @rustbot @Zalathar @bors @Mark-Simulacrum @jackh726