Skip to content

Conversation

@bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Oct 30, 2025

This is likely the last part necessary for rust-lang/miri#4648. Miri needs to be able to do a regular check build for compile_fail doc tests to work.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 30, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 30, 2025

r? @SparrowLii

rustbot has assigned @SparrowLii.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jieyouxu
Copy link
Member

You can r=me once PR CI is green.
r? jieyouxu

@rustbot rustbot assigned jieyouxu and unassigned SparrowLii Oct 30, 2025
@bjorn3
Copy link
Member Author

bjorn3 commented Oct 30, 2025

@bors r=jieyouxu

@bors
Copy link
Collaborator

bors commented Oct 30, 2025

📌 Commit 4b9dc49 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 30, 2025
@bors
Copy link
Collaborator

bors commented Oct 30, 2025

⌛ Testing commit 4b9dc49 with merge d5419f1...

@bors
Copy link
Collaborator

bors commented Oct 30, 2025

☀️ Test successful - checks-actions
Approved by: jieyouxu
Pushing d5419f1 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 30, 2025
@bors bors merged commit d5419f1 into rust-lang:master Oct 30, 2025
12 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Oct 30, 2025
@github-actions
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 8205e6b (parent) -> d5419f1 (this PR)

Test differences

No test diffs found

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard d5419f1e97b90741d51841f800d3c697c662567d --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-x86_64-apple: 6678.3s -> 7781.9s (+16.5%)
  2. x86_64-gnu-llvm-20-2: 5106.5s -> 5669.5s (+11.0%)
  3. x86_64-gnu-aux: 7423.0s -> 6641.7s (-10.5%)
  4. dist-armv7-linux: 5039.7s -> 5560.6s (+10.3%)
  5. dist-aarch64-apple: 7489.2s -> 8263.2s (+10.3%)
  6. x86_64-mingw-2: 7579.4s -> 8253.1s (+8.9%)
  7. aarch64-msvc-2: 5036.3s -> 4608.1s (-8.5%)
  8. dist-s390x-linux: 4885.3s -> 5283.4s (+8.1%)
  9. x86_64-gnu-stable: 7079.7s -> 6537.9s (-7.7%)
  10. dist-powerpc64le-linux-musl: 5429.1s -> 5838.6s (+7.5%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@bjorn3 bjorn3 deleted the dummy_backend_check_builds branch October 30, 2025 21:02
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (d5419f1): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary 3.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
3.6% [2.2%, 4.9%] 6
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Cycles

Results (secondary -3.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-3.1% [-3.1%, -3.1%] 2
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 475.886s -> 473.872s (-0.42%)
Artifact size: 390.36 MiB -> 390.40 MiB (0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants