diagnostically note source of overruling outer forbid #34251
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Aatch (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
CI reports that And the error is that the new note-level subdiagnostic was unexpected, which is also strange because I did add an expectation comment—does the same-line form not work with |
|
CI continues to fail; I'll have to investigate more some other day. |
|
☔ The latest upstream changes (presumably #34755) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Oh dear, sorry for the delay @zackmdavis! @Manishearth or @jonathandturner, would one of you be willing to take a look? |
|
Could you rebase this and see what CI thinks of it then? I'll review after. |
zackmdavis
force-pushed
the
forbidden_on_whose_authority
branch
from
5a23319 to
6350011
Compare
|
(rebased) |
|
The failure is legitimate, it is Just add "NOTE lint level defined here" to line 16 and you should be good |
When we emit E0453 (lint level attribute overruled by outer `forbid` lint level), it could be helpful to note where the `forbid` level was set, for the convenience of users who, e.g., believe that the correct fix is to weaken the `forbid` to `deny`.
zackmdavis
force-pushed
the
forbidden_on_whose_authority
branch
from
6350011 to
661b4f0
Compare
|
@Manishearth thanks! (force-pushed) |
|
@bors r+ |
|
📌 Commit 661b4f0 has been approved by |
|
⌛ Testing commit 661b4f0 with merge 30b0a45... |
…ishearth diagnostically note source of overruling outer forbid When we emit E0453 (lint level attribute overruled by outer `forbid` lint level), it could be helpful to note where the `forbid` level was set, for the convenience of users who, e.g., believe that the correct fix is to weaken the `forbid` to `deny`. 
|
💔 Test failed - auto-win-gnu-32-opt |
|
Glancing at the buildbot log, I don't see any individual test failures; the relevant part seems to be " |
|
@bors retry
|
…ishearth diagnostically note source of overruling outer forbid When we emit E0453 (lint level attribute overruled by outer `forbid` lint level), it could be helpful to note where the `forbid` level was set, for the convenience of users who, e.g., believe that the correct fix is to weaken the `forbid` to `deny`. 
When we emit E0453 (lint level attribute overruled by outer
forbidlint level), it could be helpful to note where the
forbidlevel wasset, for the convenience of users who, e.g., believe that the correct
fix is to weaken the
forbidtodeny.