-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Prefer suggestion paths which are not doc-hidden #87349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -977,8 +977,8 @@ rustc_queries! { | |
} | ||
|
||
/// Gets the span for the identifier of the definition. | ||
query def_ident_span(def_id: DefId) -> Option<Span> { | ||
desc { |tcx| "looking up span for `{}`'s identifier", tcx.def_path_str(def_id) } | ||
query def_ident(def_id: DefId) -> Option<Ident> { | ||
desc { |tcx| "looking up ident for `{}`'s identifier", tcx.def_path_str(def_id) } | ||
separate_provide_extern | ||
} | ||
|
||
|
@@ -1552,10 +1552,14 @@ rustc_queries! { | |
desc { "calculating the missing lang items in a crate" } | ||
separate_provide_extern | ||
} | ||
query visible_parent_map(_: ()) -> DefIdMap<DefId> { | ||
|
||
query visible_parents_map(_: ()) -> DefIdMap<smallvec::SmallVec<[DefId; 4]>> { | ||
storage(ArenaCacheSelector<'tcx>) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm not sure what There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It seems it's a mem optimization, but if we don't see any regression here, then it likely doesn't matter? The code looks r=me, although I'm not 100% sure about the arena cache change. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why are we changing it in this PR? Was there a performance hit or some other error that motivated the change from arena cache to Lrc? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Unless we have reason to believe we should change this, I don't think we should change it. That reason should probably look something like "we have a perf run that shows an improvement when dropping it", or at the very least a neutral perf run with just that change. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That should still be done in a separate PR, so we can independently evaluate its effects. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @Mark-Simulacrum So, is this discussion resolved then? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Well, I'd expect that separate PR to likely get filed before this merges (in order to attempt to prevent the regression here). There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @Mark-Simulacrum I opened #92169 #92168 for that There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. and #92170 |
||
desc { "calculating the visible parent map" } | ||
} | ||
query best_visible_parent(child: DefId) -> Option<DefId> { | ||
desc { "calculating best visible parent" } | ||
} | ||
query trimmed_def_paths(_: ()) -> FxHashMap<DefId, Symbol> { | ||
storage(ArenaCacheSelector<'tcx>) | ||
desc { "calculating trimmed def paths" } | ||
|
Uh oh!
There was an error while loading. Please reload this page.