-
Notifications
You must be signed in to change notification settings - Fork 56
Add a CI workflow to publish new releases after a tag is pushed #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CC @jdno, could you please also add the token here? Thanks! |
|
This needs a rebase, but I think it's ready otherwise now that the token is there? |
Oh. Hello! 😆 Yeah, I think we can merge this. We won't know if it works until we push a tag anyway. Rebased. |
No release-plz for the automatic tags and release PRs? 🙂 |
Would you say this crate is released often enough that it is worth it? But if we can just copy CI config from another repo and it will "just work", then sure, why not :) |
Not really, but also not for many of the crates I've added it to 😆 It's just kind of convenient that you don't need to touch the repo locally to do a release. I've used this config almost everywhere though, if you want to pick it up https://github.com/rust-lang/cfg-if/blob/dbfd66354537a7d47d84c95ea28b9a6f169ba9d1/.github/workflows/publish.yaml |
Yeah, seems better than messing with tags locally. Changed to release-plz. |
Let's try it. |
Hmm, it failed (https://github.com/rust-lang/rustc-demangle/actions/runs/15611624336/job/43973685924), because it tried to publish the |
it's not published on crates.io If the maintainers don't want to publish it, you can set |
Context: rust-lang/infra-team#117
This repo has
write
access byt-compiler
andt-compiler-contributors
, and currently this workflow creates a release after a push of a tag or manually throughworkflow_dispatch
. If we don't want to give right to publish tot-compiler-contributors
, then we can remove theworkflow_dispatch
trigger, and create a branch protection to e.g.v-*
tags that would only allowt-compiler
to push.Requires a new secret
CARGO_REGISTRY_TOKEN
to be added to the secrets of this repository, which has scoped access to publishrustc-demangle
.