Refactor benchmark requests #2201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rk requests Also create benchmark requests with a struct literal in the Postgres code, to make it impossible to forget setting some fields.
To ensure that they can't be messed with from the outside.
Jamesbarford
requested changes
Jul 11, 2025
|
Good point, added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went through the current benchmark request code and did a bunch of changes, mostly in order to encode more invariants into the type system, and to only use public API for dealing with these requests. This means that tests now also have to be using the public API, instead of constructing custom state arbitrarily.
Best reviewed commit-by-commit. Sorry, this will probably conflict a lot with your next changes, it took me a while to get through this.