Skip to content

Do not exit website if there is no data #2218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 8, 2025

Conversation

Kobzol
Copy link
Member

@Kobzol Kobzol commented Aug 8, 2025

It was super annoying for local tests. Let's see if CI is fine with it.

@lqd
Copy link
Member

lqd commented Aug 8, 2025

It’s annoying when testing the UI (e.g. when using the perf.rlo remote endpoint even locally), right?

@Kobzol
Copy link
Member Author

Kobzol commented Aug 8, 2025

Yeah, well it is especially annoying when testing the new job queue system, because it is supposed to fill data from the master/release commit list, and works fine even without any existing local benchmarks. So there's no need to exit.

@Kobzol Kobzol force-pushed the site-empty-results branch from cc07698 to d7b43d7 Compare August 8, 2025 07:22
@Kobzol Kobzol requested a review from Jamesbarford August 8, 2025 07:30
@lqd
Copy link
Member

lqd commented Aug 8, 2025

Worst case you also add a --terminate-if-no-data flag for CI to avoid the handful of 5 second timeouts.

@Jamesbarford
Copy link
Contributor

Would exit(EXIT_SUCCESS) help matters? We still terminate but we don't set an error code?

Copy link
Member

@lqd lqd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine.

@lqd lqd merged commit 9ba670f into rust-lang:master Aug 8, 2025
11 checks passed
@Kobzol Kobzol deleted the site-empty-results branch August 8, 2025 08:13
@Kobzol
Copy link
Member Author

Kobzol commented Aug 8, 2025

Would exit(EXIT_SUCCESS) help matters? We still terminate but we don't set an error code?

Not really, I don't want it to terminate :D I just want to run the website locally even if there is no data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants