Make job queue handler more resilient against panics #2284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing the new system on the x64 collector, I ran into some panics caused by missing API keys that I did not configure. I realized that in the case of panic, the cron job would stop, but the website would happily chug along. That's not really ideal.
The rustc-perf codebase uses unwraps and panics on a bunch of places, and thus panics can sometime happen, e.g. from transient network or DB errors. This PR thus pre-emptively guards against the panics by restarting the job queue handler cron job when it panics.
Special care is taken to avoid a "panic loop", where we would restart the task and it would immediately panic again.