Correctly pass backend when computing benchmark detail graph #2320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This looks good to me, but do I also need to test it locally you think? |
Member
Author
|
It's kinda hard to test the detailed data locally anyway, to get a 30-day history, including the rogue Cranelift data 😆 I'd say land it and see what happens in production.. |
Member
|
The "fuck it we'll do it live" way. This is the way. |
lqd
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to do a backfill of Cranelift results, which stored some Cranelift data in the production database. This is now starting to uncover some weak spots in the querying logic where we were not selecting the right backend correctly.
This PR fixes the compile-time detailed graph endpoint.
Found here.