Skip to content

fix(check): Use Cargo's colors #4563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 28, 2025
Merged

fix(check): Use Cargo's colors #4563

merged 3 commits into from
Oct 28, 2025

Conversation

@epage
Copy link
Contributor

@epage epage commented Oct 24, 2025

With rustup checks colors being testable (#4561), this updates it to match Cargo's colors

@epage epage mentioned this pull request Oct 24, 2025
Open
@epage
Copy link
Contributor Author

epage commented Oct 24, 2025

Looks like a hang in the build and CI needs to be re-kicked off

@epage epage force-pushed the check branch 2 times, most recently from 9ebdb25 to e8f5d9d Compare October 24, 2025 16:21
@epage
Copy link
Contributor Author

epage commented Oct 24, 2025

Now a test failure that I can't reproduce


thread 'download::tests::reqwest::socks_proxy_request' panicked at src/download/tests.rs:179:13:
assertion `left == right` failed
  left: 0
 right: 1

djc
djc reviewed Oct 26, 2025
View reviewed changes
@rami3l rami3l self-assigned this Oct 28, 2025
rami3l
rami3l approved these changes Oct 28, 2025
View reviewed changes
Copy link
Member

@rami3l rami3l left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

I'm soooo sorry about missing this one, I seem to have been buried in a whole lot of GitHub notifications 🙇

@rami3l rami3l removed their assignment Oct 28, 2025
@epage epage force-pushed the check branch 2 times, most recently from 80b9b95 to 02b1314 Compare October 28, 2025 13:53
@djc djc enabled auto-merge October 28, 2025 14:03
@djc djc added this pull request to the merge queue Oct 28, 2025
Merged via the queue into rust-lang:main with commit abfce9f Oct 28, 2025
29 checks passed
@epage epage deleted the check branch October 29, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@djc djc djc approved these changes

@rami3l rami3l rami3l approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@epage @djc @rami3l