Skip to content

intrinsic-test: bringing back support for --generate-only flag #1888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

madhav-madhusoodanan
Copy link
Contributor

Summary

  1. Added support for the case when the --generate-only flag is passed. This helps with generating the Rust and C artifacts even if the compilation environment is not supported

Context

This PR is part of the changes that were originally made in the x86 extension PR #1814 for intrinsic-test, and is intended to accomodate the changes made in PRs #1862 and #1863.

cc: @folkertdev @Amanieu

@rustbot
Copy link
Collaborator

rustbot commented Jul 27, 2025

r? @sayantn

rustbot has assigned @sayantn.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@folkertdev
Copy link
Contributor

r? folkertdev

@rustbot rustbot assigned folkertdev and unassigned sayantn Jul 27, 2025
Copy link
Contributor

@folkertdev folkertdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I think we can do better (using some custom types), I'll look into that, but this at least unbreaks the workflow.

@folkertdev folkertdev added this pull request to the merge queue Jul 27, 2025
Merged via the queue into rust-lang:master with commit c75d8da Jul 27, 2025
62 checks passed
@madhav-madhusoodanan
Copy link
Contributor Author

Yes, that was my intention too.
A common interface for the common module so that we can both work in parallel, unblocked with the changes in each other's workflows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants