Update Alfa Slab One to the current version #1940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gets us multiple things that are fixed in the current version: 1. Fixes the `s` (which is very prominent on the front page) to include serifs and better visually match the other glyphs. 2. Improves the inter-letter spacing. 3. Fixes rust-lang#858 by including the `ğ` glyph used in Turkish, for example on https://www.rust-lang.org/tr/learn
Manishearth
approved these changes
Mar 27, 2024
LawnGnome
added a commit
to LawnGnome/blog.rust-lang.org
that referenced
this pull request
Oct 25, 2024
This should have been done at the same time as rust-lang/www.rust-lang.org#1940, but I forgot that the blog had its own copy of the font files. The same reasoning that applied in that PR applies here: this significantly improves the lower case `s` glyph, and generally makes the font more readable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets us multiple things that are fixed in the current version:
s(which is very prominent on the front page) to include serifs and better visually match the other glyphs.ğglyph used in Turkish, for example on https://www.rust-lang.org/tr/learnI'm aware of #867, but I think this improves the status quo without blocking any longer term typography work.
The new files are bigger because the newer version of Alfa Slab One includes more glyphs. I would think this is still worthwhile.
I have no idea if there's anything required for cache busting here, but it looks like the default cache control header only has a TTL of one hour, so it's probably fine to do nothing. 🤷
Before and after examples:
English "Rust" on the home page:
Turkish "Learn Rust" heading: