Update js dependencies #1963
Merged
Update js dependencies #1963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are just dev tools that seem to be unused. I'm only updating to get the (false positive) security warnings to go away.
Lighthouse 12 works fine. Stylelint also works, but it catches much more stuff than the previous version. So it would be some work to make our scss "idiomatic". I haven't done that work and wouldn't want to. But the previous version was also throwing some errors, so it's not like the scss was meticulously kept "stylelint-compliant" in the past. I guess it makes sense to keep the tool around in case it becomes useful in the future.
stylelint-config-standard-scssseems to be the recommended config for scss these days.