Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the all group with 3 updates #2014

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 22, 2024

Bumps the all group with 3 updates: toml, rust_team_data and handlebars.

Updates toml from 0.8.14 to 0.8.15

Commits
  • 9217e44 chore: Release
  • 003ce94 docs: Update changelog
  • b463f3d Merge pull request #757 from epage/key
  • 3d8852b fix(encode): Be extra sure it can be a literal
  • e1bc1c3 refactor(encode): Pull out literal inference
  • fbb0ac2 test(encode): Add property-based tests for keys/strings
  • 0b268f2 fix(encode): Correct encoding for key with mixed quotes
  • 82c0195 refactor(encode): Make str repr inferring clearer
  • 330b590 refactor(encode): Extract all str repr inferring
  • 00fb5ee test(edit): Add more roundtrip testing
  • Additional commits viewable in compare view

Updates rust_team_data from b95a65d to 1b3d756

Commits

Updates handlebars from 5.1.2 to 6.0.0

Release notes

Sourced from handlebars's releases.

v6.0.0

What's Changed

See manually crafted changelog here: https://github.com/sunng87/handlebars-rust/blob/master/CHANGELOG.md#600---2024-07-20

New Contributors

Full Changelog: sunng87/handlebars-rust@v5.1.2...v6.0.0

Changelog

Sourced from handlebars's changelog.

6.0.0 - 2024-07-20

  • [Fixed] Various indent issue with partials, empty lines and helpers #646 #654 #658
  • [Fixed] Bug when accessing nested path #651
  • [Added] New public access to PathSeg #656
  • [Added] New API to set single block params in BlockContext #655
  • [Added] From<RenderError> for RenderErrorReason #644
  • [Changed] Add non_exhaustive attribute to all public memebers #647
  • [Changed] RenderContext API and improved performance for partial rendering #661 #662
  • [Changed] Improved error messsage for template parsing #638
Commits
  • a4b978e (cargo-release) version 6.0.0
  • c5a0173 chore: update changelog for upcoming release
  • 0af6fdc Merge pull request #662 from cmrschwarz/eliminate_rc_inner
  • b9bbd80 Merge pull request #663 from cmrschwarz/zero_alloc_indent_write
  • cace44d add zero allocation indenting function
  • 51808b9 add nested partials benchmark
  • 64b709c eliminate RenderContextInner
  • 080b5e0 Merge pull request #661 from cmrschwarz/avoid_context_clone_v2
  • 1adbc0a remove some outdated comments in expand_partial
  • 653b348 restore dev mode funcationality
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

Bumps the all group with 3 updates: [toml](https://github.com/toml-rs/toml), [rust_team_data](https://github.com/rust-lang/team) and [handlebars](https://github.com/sunng87/handlebars-rust).


Updates `toml` from 0.8.14 to 0.8.15
- [Commits](toml-rs/toml@toml-v0.8.14...toml-v0.8.15)

Updates `rust_team_data` from `b95a65d` to `1b3d756`
- [Commits](rust-lang/team@b95a65d...1b3d756)

Updates `handlebars` from 5.1.2 to 6.0.0
- [Release notes](https://github.com/sunng87/handlebars-rust/releases)
- [Changelog](https://github.com/sunng87/handlebars-rust/blob/master/CHANGELOG.md)
- [Commits](sunng87/handlebars-rust@v5.1.2...v6.0.0)

---
updated-dependencies:
- dependency-name: toml
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: all
- dependency-name: rust_team_data
  dependency-type: direct:production
  dependency-group: all
- dependency-name: handlebars
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: all
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file rust Pull requests that update Rust code labels Jul 22, 2024
@cmrschwarz
Copy link

cmrschwarz commented Jul 25, 2024

I stumbled upon this as the guy partially responsible for the recent Handlebars 6.0 changes.

I was surprised to see us causing your build to fail and looked into it. Sorry!

The reason seems to be that you are using rocket_dyn_templates, which in it's currently released version bundles handlebars 5.1. (They updated on master, but haven't had a release yet).

But you also depend on handlebars directly, using version 6.0, which is of course semver incompatible with 5.1.

The scary error message mainly says: expected rocket_dyn_templates::handlebars::Helper,
found handlebars::Helper, which are of course not the same type because of semver.

I suggest simply waiting until rocket_dyn_templates updates.

You could alternatively fix the error right now by changing these two use statements from handlebars:: to rocket_dyn_templates::handlebars::, but unfortunately due to the dependency diamond of

rocket_dyn_templates    ->    handlebars    <-    handlebars_fluent


                 ^            rust-lang.org            ^
                                   

You might still end up being hosed if those two dependencies disagree on the (major) version of hbs.
I don't expect us doing a major release anytime soon again, so this should hopefully be a one time thing.

If it serves as consolation, 6.0 should get you a decent perf boost, lower memory consumption and correctly indented html in return.
Cheers

@senekor senekor mentioned this pull request Jul 25, 2024
@senekor
Copy link
Contributor

senekor commented Jul 25, 2024

@cmrschwarz Thank you for the helpful comment! It's nice to be "looked after" as a downstream 😉 Your suggestion worked, I fixed it on #2015.

Copy link
Contributor Author

dependabot bot commented on behalf of github Jul 26, 2024

Looks like these dependencies are no longer updatable, so this is no longer needed.

@dependabot dependabot bot closed this Jul 26, 2024
@dependabot dependabot bot deleted the dependabot/cargo/all-a31dc0feb8 branch July 26, 2024 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants