Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move launching pad to its own page #2105

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Jan 13, 2025

This changes the governance page so that the launching pad has its own page. All the working groups are moved from the top-level page to show up under the launching-pad page instead.

One of the intentions here is to support showing team members for non-working-groups in the launching pad. Currently there is no way to view them.

I suspect that we will keep the launching pad for a long time, as it will take a while to reorganize everything. It's also unclear if we should keep the launching-pad indefinitely, or if there will be some point where we will remove it. I think once we reach that point, then we'll just remove the launching-pad page.

The old links for things like https://www.rust-lang.org/governance/wgs/wg-security-response continue to work, but there are no direct links to them anymore.

@ehuss
Copy link
Contributor Author

ehuss commented Jan 13, 2025

This requires a companion change to rust-lang/team for this to work (rust-lang/team#1643).

cc @jamesmunns I don't know if you think this might be a good idea.

Unfortunately I don't have a good way to show you a preview of what this looks like. Just imagine https://www.rust-lang.org/governance without the green "Working Groups" section, and instead a link in the "Teams" section to the Launching Pad that has a list of all the launching-pad teams and their members.

I don't know if this is really the best approach, but I couldn't think of a good alternative. We could keep the "Working Groups" list at the bottom, but I don't know why we would do that. That is not a complete list, and I'm not sure why we would want to highlight them on the top-level page.

@apiraino
Copy link
Contributor

Question without seeing the changes: how does the website will behave with links currently indexed by search engines? Will there be any broken links? Autoredirects?

@ehuss
Copy link
Contributor Author

ehuss commented Jan 13, 2025

The old working-group pages continue to exist as they did before.

@ehuss
Copy link
Contributor Author

ehuss commented Feb 10, 2025

@senekor or @Manishearth I'm curious what you think about this change? Would you like to move forward with it?

@senekor
Copy link
Contributor

senekor commented Feb 10, 2025

seems like a reasonable change to me, I have nothing to object 🙂

@Manishearth
Copy link
Member

Fine by me!

@jamesmunns
Copy link
Member

Noted in rust-lang/team#1643, but the change looks reasonable to me!

@ehuss ehuss marked this pull request as ready for review February 17, 2025 15:19
@ehuss ehuss requested a review from a team as a code owner February 17, 2025 15:19
@ehuss
Copy link
Contributor Author

ehuss commented Feb 17, 2025

The team PR has been merged, so I think this is ready to go.

@Manishearth Manishearth merged commit c242f19 into rust-lang:master Feb 17, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants