Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client side routing #2

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Client side routing #2

wants to merge 14 commits into from

Conversation

kodesoul
Copy link

@kodesoul kodesoul commented May 8, 2022

This patch adds a basic client side router and the beginnings of the Sign Up page.

maretekent
maretekent approved these changes Jun 30, 2022
View reviewed changes
Copy link
Collaborator

@maretekent maretekent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I hope we can refactor the code more to separate a lot of concerns like routes and components. That way we can have a sort of single responsibility files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maretekent maretekent maretekent approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kodesoul @maretekent