Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nip15 #174

Closed
wants to merge 1 commit into from
Closed

Nip15 #174

wants to merge 1 commit into from

Conversation

tompro
Copy link
Contributor

@tompro tompro commented Oct 10, 2023

Description

Added models and event builders for nip15.

Notes

Had some trouble with clang on macOs (m2) for precommit, no issues on linux though.

@tompro
Copy link
Contributor Author

tompro commented Oct 10, 2023

Sry should have checked out my branch before running precommit on Linux

Copy link
Member

@yukibtc yukibtc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I flagged some changes to do. Also, can you squash commits together? So will remain a single commit, like: "nostr: add NIP15 support" (git log it's more readable in this way)

crates/nostr/Cargo.toml Outdated Show resolved Hide resolved
crates/nostr/src/nips/nip15.rs Outdated Show resolved Hide resolved
crates/nostr/examples/nip15.rs Outdated Show resolved Hide resolved
crates/nostr/src/nips/nip15.rs Outdated Show resolved Hide resolved
- builders, tests, example
yukibtc added a commit that referenced this pull request Oct 11, 2023
@yukibtc yukibtc closed this Oct 11, 2023
@yukibtc
Copy link
Member

yukibtc commented Oct 11, 2023

Merged: 2b273c9

@tompro tompro deleted the nip15 branch October 11, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants