Make the build reproducible #355
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
numtraits' build script causes non-reproducible autocfg's files to be written to
OUT_DIR
:Those hashes in the filenames and the contents of the files will be different for every build.
This causes issues in build systems like bazel with rules_rust that treat
OUT_DIR
as the package's output. Since the output is different for every build it means reverse dependencies of num-traits have to be rebuild every time num-traits changes.We fix this by adapting the build script to let autocfg write its intermediate files to a temporary directory.